-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bridge filament basic render infrastructure #9
Conversation
372b19c
to
6e3b6eb
Compare
this.choreographer.addOnFrameListener((timestamp) => {
// ...
}) Make sure to keep a reference on the returned listener, otherwise it might be destroyed I think? Not sure about that. const listener = this.choreographer.addOnFrameListener((timestamp) => {
// ...
})
// .. later
listener.remove() We can also change the implementation of |
…feat/first-render-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty good - left some comments!
Co-authored-by: Marc Rousavy <me@mrousavy.com>
Co-authored-by: Marc Rousavy <me@mrousavy.com>
Co-authored-by: Marc Rousavy <me@mrousavy.com>
Co-authored-by: Marc Rousavy <me@mrousavy.com>
Co-authored-by: Marc Rousavy <me@mrousavy.com>
} | ||
|
||
_scene = scene; | ||
_view->setScene(scene->getScene().get()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to think about this as well - I see this a lot in your code where we do set(get->get())
which might be a bit unsafe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now its fine
Changes
Example
We can't see anything yet but the basic render infrastructure is there in FilamentView.tsx
Note:
Android will crash once start rendering, as it can't render anything without any entities in the scene (not sure why its not an issue on iOS though)