added support for angular 1.5 component #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also PR #163 @marcoslin |
|
Thanks @andidev. I did notice belatedly that someone else already made an identical pull request, but I didn't see the comments. For some reason I can't get npm test to run successfully on my windows machine even with a bash shell, so I've been relying on travis-ci. |
|
@andidev you're right, I undid my changes and pushed, the build is still breaking |
|
Hi there, does it function meanwhile? I mean the component support? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'd like to add support for Angular 1.5 components.
I've tried creating a simple component with it (just passed an object in and display the value) and it worked. I used Dojo as my AMD loader, though I expect it should also work with Requirejs.
Angular 1.5 components pass a JS object (option) instead of a function (constructor) as the second parameter, but since everything is just being passed directly to Angular I don't see this being an issue.
BTW I would like to mention that the way angularAMD was written, it made it easy to add support for an additional Angular feature. Thanks for making the code easy to modify, and thank you for making angularAMD.