Fix unwanted roll #5083 #5092
Fix unwanted roll #5083 #5092
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5092 +/- ##
=======================================
Coverage 91.80% 91.81%
=======================================
Files 279 279
Lines 38332 38341 +9
Branches 4999 4998 -1
=======================================
+ Hits 35192 35201 +9
Misses 3007 3007
Partials 133 133 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
NathanMOlson
changed the title
| tr.setRoll(eulerAngles.roll); | ||
| tr.setPitch(eulerAngles.pitch); | ||
| tr.setBearing(eulerAngles.bearing); | ||
| export function updateRotation(startRotation: quat, endRotation: quat, startEulerAngles: RollPitchBearing, endEulerAngles: RollPitchBearing, tr: ITransform, k: number, useSlerp: boolean) { |
There was a problem hiding this comment.
It might be better to define a type for this method to pass the parameters as there are many parameters now, too many for my taste...
|
We've just migrated the code to vitest, I'm trying to figure out if the coverage reports is accurate. |
It appear to be reporting at least some code as Covered on main And uncovered in this PR Despite being identical |
|
The report comment is saying that there is a missing uploaded file (8 files instead of 9). |
Launch Checklist
Fix #5083.
Use spherical linear interpolation only when
rollEnabledis true. Otherwise, use linear interpolation of Euler angles.CHANGELOG.mdunder the## mainsection.