Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose pure MASA c++ interface #26

Open
nicholasmalaya opened this issue Apr 1, 2015 · 3 comments
Open

Expose pure MASA c++ interface #26

nicholasmalaya opened this issue Apr 1, 2015 · 3 comments
Milestone

Comments

@nicholasmalaya
Copy link
Member

Instead of forcing user to call sets of functions, al la:

masa_init();
masa_init_param();
masa_sanity_check();

etc.

Put together the c++ interface so that all are member functions of a masa class, i.e.:

MASA foo;
foo.init();
foo.init_param();
foo.sanity();

etc.

Should not be too hard. Will require reworking masa core routines, as well as wrappers for c and fortran. Also, all cpp regression tests will need fixin'.

Was requested by @pbauman and @vikramvgarg. This is not an API change but significant enough I would like it to be independent of current masa release targets (0.44). Likely will be named 0.50.

@nicholasmalaya nicholasmalaya added this to the 0.50 milestone Apr 1, 2015
@roystgnr
Copy link
Member

roystgnr commented Apr 1, 2015

Why a new MASA class rather than the existing MasterMS class?

@nicholasmalaya
Copy link
Member Author

This is not a new class -- as the title implies the intent is to expose the existing class and methods.

@roystgnr
Copy link
Member

roystgnr commented Apr 1, 2015

I see "MASA foo;" in the issue.

I see "namespace MASA" but not "class MASA" in the code. Where is the existing class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants