Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance tasks for PolarizationEfficiencyCor #38287

Open
2 tasks
rbauststfc opened this issue Oct 24, 2024 · 0 comments · May be fixed by #38458
Open
2 tasks

Maintenance tasks for PolarizationEfficiencyCor #38287

rbauststfc opened this issue Oct 24, 2024 · 0 comments · May be fixed by #38458
Assignees
@yusufjimoh
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period. Reflectometry Issues and pull requests related to reflectometry
Milestone
Release 6.12

Comments

@rbauststfc
Copy link
Contributor

rbauststfc commented Oct 24, 2024 •
edited
Loading

Following on from #37672 we have identified the following maintenance that would be good to do for algorithm PolarizationEfficiencyCor:

  • We should add unit tests to check that you cannot use the Fredrikze input and output spin state properties when performing a Wildes correction.

  • The unit test code for PolarizationEfficiencyCor would benefit from reducing some of the code duplication and potentially improving some of the readability to help us maintain and extend it over the longer term.
@rbauststfc rbauststfc added Reflectometry Issues and pull requests related to reflectometry Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS labels Oct 24, 2024
@rbauststfc rbauststfc added this to the Release 6.12 milestone Oct 24, 2024
@rbauststfc rbauststfc moved this from New to Backlog in ISIS LSS Sprint Planning Oct 24, 2024
@rbauststfc rbauststfc mentioned this issue Oct 25, 2024
Merged
@yusufjimoh yusufjimoh self-assigned this Nov 26, 2024
@yusufjimoh yusufjimoh moved this from Backlog to In Progress in ISIS LSS Sprint Planning Nov 28, 2024
@yusufjimoh yusufjimoh linked a pull request Nov 28, 2024 that will close this issue
Draft
@yusufjimoh yusufjimoh linked a pull request Nov 28, 2024 that will close this issue
Update Unit Tests in PolarizationEffiency Cor #38458
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yusufjimoh yusufjimoh

Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period. Reflectometry Issues and pull requests related to reflectometry
Projects
ISIS LSS Sprint Planning
Status: In Progress
Milestone
Release 6.12
Development

Successfully merging a pull request may close this issue.

Update Unit Tests in PolarizationEffiency Cor mantidproject/mantid
2 participants
@rbauststfc @yusufjimoh