Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match return value types to PromoStandards specifications #2

Open
manishrc opened this issue Nov 27, 2018 · 0 comments
Open

Match return value types to PromoStandards specifications #2

manishrc opened this issue Nov 27, 2018 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@manishrc
Copy link
Owner

The SDK currently converts any value to a native type irrespective of the expected type according to https://promostandards.org/service/view/7/

Example:
If a productId is found to be 5790, it's converted to a number while PromoStandards expects a string.

Need to ensure that the return types match the PromoStandards specifications efficiently.
@manishrc manishrc added the help wanted Extra attention is needed label Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@manishrc