Merge pull request #728 from jmrenouard/master

Join Buffer Size recommendation Link Broken #722
major · Sep 9, 2023 · 8efc22d · 8efc22d
2 parents 76c2156 + 290b32d
commit 8efc22d
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 9 deletions.
diff --git a/.github/workflows/publish_release.yml b/.github/workflows/publish_release.yml
@@ -32,8 +32,6 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           upload_url: ${{ steps.create_release.outputs.upload_url }}
-          asset_path: ./path/to/asset.zip
-          asset_name: asset.zip
           asset_content_type: application/zip
       - name: Publish release
         uses: StuYarrow/publish-release@v1.1.2

diff --git a/Makefile b/Makefile
@@ -49,18 +49,24 @@ increment_sub_version:
 	sed -i "s/$(VERSION)/$(UPDATE_SUB_VERSION)/" mysqltuner.pl *.md .github/workflows/*.yml
 	git add ./*.md ./mysqltuner.pl
 	git commit -m "Generate $(UPDATE_SUB_VERSION) sub version at $(shell date --iso=seconds)"
+	git tag -a v$(UPDATE_SUB_VERSION) -m "Generate $(UPDATE_SUB_VERSION) sub version at $(shell date --iso=seconds)"
+	git push --tags
 
 increment_minor_version:
 	@echo "Incrementing minor version from $(VERSION) to $(UPDATE_MINOR_VERSION)"
 	sed -i "s/$(VERSION)/$(UPDATE_MINOR_VERSION)/" mysqltuner.pl *.md .github/workflows/*.yml
 	git add ./*.md ./mysqltuner.pl
-	git commit -m "Generate $(UPDATE_SUB_VERSION) minor version at $(shell date --iso=seconds)"
+	git commit -m "Generate $(UPDATE_MINOR_VERSION) minor version at $(shell date --iso=seconds)"
+	git tag -a v$(UPDATE_MINOR_VERSION) -m "Generate $(UPDATE_MINOR_VERSION) minor version at $(shell date --iso=seconds)"
+	git push --tags
 
 increment_major_version:
 	@echo "Incrementing major version from $(VERSION) to $(UPDATE_MAJOR_VERSION)"
 	sed -i "s/$(VERSION)/$(UPDATE_MAJOR_VERSION)/" mysqltuner.pl *.md .github/workflows/*.yml
 	git add ./*.md ./mysqltuner.pl
 	git commit -m "Generate $(UPDATE_SUB_VERSION) major version at $(shell date --iso=seconds)"
+	git tag -a v$(UPDATE_MINOR_VERSION) -m "Generate $(UPDATE_MAJOR_VERSION) major version at $(shell date --iso=seconds)"
+	git push --tags
 
 push:
 	git push
diff --git a/USAGE.md b/USAGE.md
@@ -1,6 +1,6 @@
 # NAME
 
-    MySQLTuner 2.2.9 - MySQL High Performance Tuning Script
+    MySQLTuner 2.2.12 - MySQL High Performance Tuning Script
 
 # IMPORTANT USAGE GUIDELINES
 

diff --git a/mysqltuner.pl b/mysqltuner.pl
@@ -1,5 +1,5 @@
 #!/usr/bin/env perl
-# mysqltuner.pl - Version 2.2.9
+# mysqltuner.pl - Version 2.2.12
 # High Performance MySQL Tuning Script
 # Copyright (C) 2015-2023 Jean-Marie Renouard - jmrenouard@gmail.com
 # Copyright (C) 2006-2023 Major Hayden - major@mhtx.net
@@ -57,7 +57,7 @@ package main;
 #use Env;
 
 # Set up a few variables for use in the script
-my $tunerversion = "2.2.9";
+my $tunerversion = "2.2.12";
 my ( @adjvars, @generalrec );
 
 # Set defaults
@@ -3562,8 +3562,7 @@ sub mysql_stats {
         push(
             @generalrec,
 "We will suggest raising the 'join_buffer_size' until JOINs not using indexes are found.
-             See https://dev.mysql.com/doc/internals/en/join-buffer-size.html
-             (specially the conclusions at the bottom of the page)."
+             See https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_join_buffer_size"
         );
     }
     else {
@@ -7357,7 +7356,7 @@ sub which {
 
 =head1 NAME
 
- MySQLTuner 2.2.9 - MySQL High Performance Tuning Script
+ MySQLTuner 2.2.12 - MySQL High Performance Tuning Script
 
 =head1 IMPORTANT USAGE GUIDELINES