Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't check the response of send() #148

Open
lucafaggianelli opened this issue Aug 6, 2024 · 0 comments
Open

Can't check the response of send() #148

lucafaggianelli opened this issue Aug 6, 2024 · 0 comments

Comments

@lucafaggianelli
Copy link

Describe the bug
The response of the method mailer.send(mail_body) is a string that doesn't allow to check the response code.

To Reproduce
Steps to reproduce the behavior:

  1. Call mailer.send(mail_body)
  2. Check if the email was sent or not

Expected behavior
I expect the mailer.send(mail_body) method to return a proper HTTP response or raise an Exception in case of error

Given the current implementation of the method send, please just return the response instead of a str, today implementation:

return f"{request.status_code}\n{request.text}"

Environment (please complete the following information):

  • OS: macOS
  • Python version 3.12
  • SDK version 0.5.8

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant