increase minimum password length

magento · Nov 16, 2024 · f189ff8 · f189ff8
1 parent 6acfd6a
commit f189ff8
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/app/code/Magento/User/Model/UserValidationRules.php b/app/code/Magento/User/Model/UserValidationRules.php
@@ -24,7 +24,7 @@ class UserValidationRules
     /**
      * Minimum length of admin password
      */
-    public const MIN_PASSWORD_LENGTH = 7;
+    public const MIN_PASSWORD_LENGTH = 12;
 
     /**
      * Adds validation rule for user first name, last name, username and email

diff --git a/dev/tests/integration/framework/Magento/TestFramework/Bootstrap.php b/dev/tests/integration/framework/Magento/TestFramework/Bootstrap.php
@@ -15,7 +15,7 @@ class Bootstrap
      * Predefined admin user credentials
      */
     public const ADMIN_NAME = 'user';
-    public const ADMIN_PASSWORD = 'password1';
+    public const ADMIN_PASSWORD = 'password1234';
     public const ADMIN_EMAIL = 'admin@example.com';
     public const ADMIN_FIRSTNAME = 'firstname';
     public const ADMIN_LASTNAME = 'lastname';

diff --git a/lib/web/mage/validation.js b/lib/web/mage/validation.js
@@ -685,13 +685,13 @@ define([
                     return false;
                 }
 
-                if (pass.length < 7) {
+                if (pass.length < 12) {
                     return false;
                 }
 
                 return true;
             },
-            $.mage.__('Please enter 7 or more characters, using both numeric and alphabetic.')
+            $.mage.__('Please enter 12 or more characters, using both numeric and alphabetic.')
         ],
         'validate-customer-password': [
             function (v, elm) {

diff --git a/setup/src/Magento/Setup/Fixtures/AdminUsersFixture.php b/setup/src/Magento/Setup/Fixtures/AdminUsersFixture.php
@@ -98,7 +98,7 @@ public function execute()
                 ->setFirstName('Firstname')
                 ->setLastName('Lastname')
                 ->setUserName('admin' . $i)
-                ->setPassword('123123q')
+                ->setPassword('1234512345q!')
                 ->setIsActive(1);
             $adminUser->save();
         }

diff --git a/setup/src/Magento/Setup/Test/Unit/Console/Command/AdminUserCreateCommandTest.php b/setup/src/Magento/Setup/Test/Unit/Console/Command/AdminUserCreateCommandTest.php
@@ -62,14 +62,14 @@ public function testExecute(): void
     {
         $options = [
             '--' . AdminAccount::KEY_USER => 'user',
-            '--' . AdminAccount::KEY_PASSWORD => '123123q',
+            '--' . AdminAccount::KEY_PASSWORD => '1234512345q!',
             '--' . AdminAccount::KEY_EMAIL => 'test@test.com',
             '--' . AdminAccount::KEY_FIRST_NAME => 'John',
             '--' . AdminAccount::KEY_LAST_NAME => 'Doe'
         ];
         $data = [
             AdminAccount::KEY_USER => 'user',
-            AdminAccount::KEY_PASSWORD => '123123q',
+            AdminAccount::KEY_PASSWORD => '1234512345q!',
             AdminAccount::KEY_EMAIL => 'test@test.com',
             AdminAccount::KEY_FIRST_NAME => 'John',
             AdminAccount::KEY_LAST_NAME => 'Doe',