Implement missing methods

madurangasiriwardena · Feb 10, 2024 · b5ff108 · b5ff108
1 parent ab01d3f
commit b5ff108
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/...t/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/IdPManagementDAO.java b/...t/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/IdPManagementDAO.java
@@ -2901,8 +2901,12 @@ private void fillResidentIdpProperties(IdentityProvider identityProvider, String
     public IdentityProvider getIDPbyId(Connection dbConnection, int idpId, int tenantId,
                                        String tenantDomain) throws IdentityProviderManagementException {
 
-        return getIDP(dbConnection, null, idpId, null, tenantId, tenantDomain);
-
+        IdentityProvider idp = getIDP(dbConnection, null, idpId, null, tenantId, tenantDomain);
+        if (idp != null
+                && IdentityApplicationConstants.RESIDENT_IDP_RESERVED_NAME.equals(idp.getIdentityProviderName())) {
+            fillResidentIdpProperties(idp, tenantDomain);
+        }
+        return idp;
     }
 
     /**
@@ -3396,6 +3400,7 @@ public IdentityProvider getIdPByAuthenticatorPropertyValue(Connection dbConnecti
                         getIdentityPropertiesByIdpId(dbConnection, Integer.parseInt(rs.getString("ID"))));
                 if (IdentityApplicationConstants.RESIDENT_IDP_RESERVED_NAME.equals(idPName)) {
                     propertyList = resolveConnectorProperties(propertyList, tenantDomain);
+                    fillResidentIdpProperties(federatedIdp, tenantDomain);
                 }
                 federatedIdp.setIdpProperties(propertyList.toArray(new IdentityProviderProperty[0]));
 
@@ -3558,6 +3563,7 @@ public IdentityProvider getIdPByAuthenticatorPropertyValue(Connection dbConnecti
 
                 if (IdentityApplicationConstants.RESIDENT_IDP_RESERVED_NAME.equals(idPName)) {
                     propertyList = resolveConnectorProperties(propertyList, tenantDomain);
+                    fillResidentIdpProperties(federatedIdp, tenantDomain);
                 }
                 federatedIdp.setIdpProperties(propertyList.toArray(new IdentityProviderProperty[0]));