Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid the callback hell and use promises instead #90

Closed
jamesgeorge007 opened this issue Mar 4, 2019 · 5 comments
Closed

Avoid the callback hell and use promises instead #90

jamesgeorge007 opened this issue Mar 4, 2019 · 5 comments
Labels

Comments

@jamesgeorge007
Copy link
Member

jamesgeorge007 commented Mar 4, 2019

Currently gitRepo.js comprises of nested callbacks making the code ambiguous. It has to be replaced with a promisified approach.

Use async/await and promises

Check out herokuDeployjs

@mansi-m3006
Copy link

can I work on this issue?

@anto-christo
Copy link
Contributor

Sure, go ahead 👍

@anto-christo anto-christo added assigned and removed up-for-grabs Up for grabs labels Mar 10, 2019
@ani-sha
Copy link

ani-sha commented Mar 20, 2019

Can I work on this issue?

@anto-christo
Copy link
Contributor

Hi @ani-sha , glad to see you interested in this issue. But this has already been assigned to another participant. The other participant is hopefully working on it and may send a PR. We can assign you this if the previous participant fails to do so. Till then I request you to have a look at other issues. I recommend you #81 . The participant assigned to #81 has not been responsive, so if you are interested, we can assign #81 to you.

@ani-sha
Copy link

ani-sha commented Apr 2, 2019

@anto-christo Sorry for the late reply I was out of station.
Yes i would like to work on #81 issue. Please assign me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants