Revert the depends_on change

It causes data sources to be read too late resulting in unexpected changes.

See https://itnext.io/beware-of-depends-on-for-modules-it-might-bite-you-da4741caac70

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 2.6.6 (2023-02-14)
+ - Revert the `depends_on` change since it causes data sources to be read too
+   late resulting in unexpected changes.
+   See https://itnext.io/beware-of-depends-on-for-modules-it-might-bite-you-da4741caac70
+
 ## 2.6.5 (2023-02-14)
  - Set `depends_on` on components (modules) when output variables are used. This
    turned out to be neccessary when the variables were used in data sources.

internal/generator/generate.go

@@ -169,7 +169,7 @@ func renderComponent(cfg *config.MachConfig, site *config.SiteConfig, component
 		Source:           component.Definition.Source,
 		PluginResources:  []string{},
 		PluginVariables:  []string{},
-		PluginDependsOn:  findDependsOn(component.Variables),
+		PluginDependsOn:  []string{},
 		PluginProviders:  []string{},
 	}
 

internal/generator/hcl.go

@@ -11,7 +11,6 @@ import (
 )
 
 var regexVars = regexp.MustCompilePOSIX(`"\$\$\{([^\}]+)\}"`)
-var regexTFVar = regexp.MustCompilePOSIX(`\$\{([^\}]+)\}`)
 
 func serializeToHCL(attributeName string, data any) (string, error) {
 	val, err := asCTY(data)
@@ -55,13 +54,3 @@ func asCTY(source any) (cty.Value, error) {
 
 	return ctyJsonVal.Value, nil
 }
-
-func findVariables(input string) []string {
-	matches := regexTFVar.FindAllStringSubmatch(input, -1)
-	result := []string{}
-	for _, match := range matches {
-		item := match[1]
-		result = append(result, item)
-	}
-	return result
-}