Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed URL highlighting on wrapping #564

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Fixed URL highlighting on wrapping #564

merged 1 commit into from
Nov 29, 2024

Conversation

tsujan
Copy link
Member

@tsujan tsujan commented Nov 18, 2024

Previously, if a line consisted of two URLs separated by a space and was wrapped at the end of that space, both URLs were underlined if the cursor was on each of them.

An example of wrapping by resizing QTerminal (for testing):

abc://aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa 
abc://aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

Note that there is a space at the end of the first line.

Fixes lxqt/qterminal#1184

Previously, if a line consisted of two URLs separated by a space and was wrapped at the end of that space, both URLs were underlined if the cursor was on each of them.

An example of wrapping by resizing QTerminal (for testing):

```
abc://aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
abc://aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
```

Note that there is a space at the end of the first line.

Fixes lxqt/qterminal#1184
@tsujan
Copy link
Member Author

tsujan commented Nov 18, 2024

@stefonarch
I've tested it, but your tests would be really appreciated.

@tsujan tsujan merged commit 4301bc2 into master Nov 29, 2024
@tsujan tsujan deleted the fix_url_highlight branch November 29, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small problem with URL highlighting
1 participant