remaining relevant vm fields added #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luthermonson
approved these changes
Aug 27, 2023
Codecov Report
@@ Coverage Diff @@
## vm-updates #87 +/- ##
==============================================
- Coverage 20.72% 20.70% -0.03%
==============================================
Files 15 15
Lines 1655 1657 +2
==============================================
Hits 343 343
- Misses 1291 1293 +2
Partials 21 21
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
so where did you find these other fields? I'm looking here: https://pve.proxmox.com/pve-docs/api-viewer/#/nodes/{node}/qemu/{vmid}/status/current but you seem to have found things i never noticed. |
|
Well, the pve-docs seem to be outdated. My Node is running Proxmox 8.0.3 and has those fields. |
|
I requested the API with Postman |
|
could you get the data from those requests and anonymize them a bit and put it in a quick test so the unmarshalling is confirmed working? take a look at how i did the rdddata test |
|
oh, you probably use ceph! i bet ill never see that blockstat stuff. not sure why NIC wasn't coming back. do you use SDN too? |
|
Yes, I'll try. Codecov doesn't seem to like the Timestamp function within the struct too. |
|
I actually never used CEPH and SDN |
|
welp i upgraded one of my proxmox nodes to 8 and i still dont have those fields... i literally have no idea how you found them then :D whatever, extra struct fields dont hurt anyone else so they'll get merged |
|
that one will get covered if do a test to pull a vm and assert the timestamp is equal to something. codecov is... just a suggestion ill still merge PRs with missing coverage |
|
this should be pretty close to what you need for a test https://github.com/luthermonson/go-proxmox/blob/main/virtual_machine_test.go#L11-L24 and then just put your json in a gock call so a |
Parsed without any errors. |
|
Can I get the json response your getting from postman and I'll wrap a test around it. Make sure to anonymize anything that you don't want public |
|
Below are the unmodified JSON Body from RRDDATA and Status vm.Ping()
|
|
great! thanks for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.