Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rrddata Endpoint Support & Missing/Outdated Elements in various structs #84

Closed
MattBGP opened this issue Aug 26, 2023 · 3 comments · Fixed by #85
Closed

rrddata Endpoint Support & Missing/Outdated Elements in various structs #84

MattBGP opened this issue Aug 26, 2023 · 3 comments · Fixed by #85

Comments

@MattBGP
Copy link

MattBGP commented Aug 26, 2023

Hi there,

I was wondering if there is planning on implementing the rrddata Endpoint /api2/json/nodes/pve/qemu/<vmid>/rrddata
With that I also have another question, why is the VirtualMachine struct and several other structs that outdated? There are several elements missing. The Library still seems to be actively maintained and updated except for the described issue. Is this on purpose?

Thank you in advance! :)

@luthermonson
Copy link
Owner

I'm sure I wrote the vm stuff in 6.x and more have since come out. I'll give it a refresh, thanks for the input. RE the other end point, sure! Let me look at into it at the same time.

@luthermonson
Copy link
Owner

take a look at the PR and see if that will work for you

@MattBGP
Copy link
Author

MattBGP commented Aug 27, 2023

Hi, looks good, added remaining relevant fields and created #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants