Addition of Refresh Rate Customization as an Optional Feature #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 22, 2023 12:48
…rrors for non-nullables so I added '#nullable enable' to the helper class.
|
I've realized that the update to this program 11 months ago broke the powershell module due to how the newer versions of .net handle null coalescing. I've added a working module under cds_legacy which includes the updates to refresh rate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the -RefreshRate parameter for the PowerShell module and the -r flag for the executable, enabling users to specify a custom refresh rate. The addition enhances flexibility and user control, catering to varying hardware setups and preferences. It integrates into the existing codebase, with attention to backward compatibility.
Instead of adding additional ChangeDisplaySettings overload methods, I chose to implement RefreshRate with the default parameter of 0 and with a conditional in ChangeDisplaySettings. This decision was made for simplicity and readability.