Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minContribution could be passed as an init() argument #35

Open
i-stam opened this issue Dec 28, 2019 · 1 comment
Open

minContribution could be passed as an init() argument #35

i-stam opened this issue Dec 28, 2019 · 1 comment
Labels
optimization Changes that improve code efficiency question Further information is requested

Comments

@i-stam
Copy link
Contributor

i-stam commented Dec 28, 2019

It will make the rICO contract more flexible and reusable.

  • range checks should be implemented (e.g. require(minContribution !=0)
@i-stam i-stam added question Further information is requested optimization Changes that improve code efficiency labels Dec 28, 2019
@mickys
Copy link
Contributor

mickys commented Dec 28, 2019

Sure, as long as we have enough stack space for another variable :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Changes that improve code efficiency question Further information is requested
Development

No branches or pull requests

2 participants