Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check if urlSearchParams exists using iterator instead of size #21

Merged
merged 1 commit into from
Apr 22, 2024
Merged

feat: check if urlSearchParams exists using iterator instead of size #21

merged 1 commit into from
Apr 22, 2024

Conversation

wontondon
Copy link
Contributor

This resolves the issue #20 I opened where older browsers don't have access to URLSearchParams.size.

@lukemorales lukemorales linked an issue Apr 22, 2024 that may be closed by this pull request
URL search params are not always created in older browser/node versions #20
Closed
lukemorales
lukemorales approved these changes Apr 22, 2024
View reviewed changes
Copy link
Owner

@lukemorales lukemorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @wontondon

@lukemorales lukemorales merged commit 7affec2 into lukemorales:main Apr 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukemorales lukemorales lukemorales approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL search params are not always created in older browser/node versions
2 participants
@wontondon @lukemorales