Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accurate transaction fee calculation #20

Open
lukechampine opened this issue Aug 15, 2019 · 0 comments
Open

More accurate transaction fee calculation #20

lukechampine opened this issue Aug 15, 2019 · 0 comments
Labels
enhancement New feature or request wallet

Comments

@lukechampine
Copy link
Owner

wallet.FundTransaction currently estimates the transaction size as len(inputs) * 241, which is inaccurate for transactions with few inputs and many outputs. I see two potential solutions: either take the number of outputs as an additional argument, or take an entire partially-filled transaction as an argument. I'm leaning towards the latter case, since it generalizes to things like file contract transactions and siafund transactions. The only downside is that passing in a partially-filled transaction is sort of a weird API.

@lukechampine lukechampine added enhancement New feature or request wallet labels Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wallet
Projects
None yet
Development

No branches or pull requests

1 participant