Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RFC for shorter vector constructor #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petrihakkinen
Copy link
Contributor

@petrihakkinen petrihakkinen commented Nov 19, 2024

Add RFC for replacing the current vector constructor (vector.create) with a less verbose version (vector).

Rendered

@petrihakkinen
Copy link
Contributor Author

petrihakkinen commented Nov 19, 2024

After a long think I decided to propose the deprecation and eventual removal of vector.create in favor of vector in the RFC because I think it would be better for the language in the long run to have only one constructor. If you think this is a too big breaking change we can modify the RFC to keep the old version as an alias. I don't have a strong opinion on that but we'd prefer some officially sanctioned way to disable vector.create (or any other built-in) locally for our codebase in case vector is added but vector.create is not deprecated.

@jackdotink
Copy link
Contributor

Personally I would like to see special syntax for creating vectors, such as <x, y, z>.

@vegorov-rbx
Copy link
Contributor

I don't think we will be adopting this.
Reasoning for current constructor was already discussed in the vector library RFC and we have selected that option to go forward.

In a way, this RFC was already rejected in the discussion of that RFC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants