Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Possibility to edit seen time as well as date #87

Closed
amadeous opened this issue May 19, 2020 · 7 comments
Closed

Feature request: Possibility to edit seen time as well as date #87

amadeous opened this issue May 19, 2020 · 7 comments

Comments

@amadeous
Copy link
Contributor

Hi there!

I hope you're doing fine. Thank you for that great app that still works after all these years!

A timestamp is used to represent the moment an episode is seen. We can then edit the seen date but not the seen time (approx., no need for seconds). Could it be easily implemented?

Motivation: I admit I sometimes forget to check episodes after seeing them. For now I can only edit the date but not the time in the day. The current trick is to mark them as seen at the same time on a following day and edit the day.

Thanks a lot!

ltguillaume added a commit that referenced this issue May 19, 2020
Add time picker dialog for seen timestamp (#87)
@ltguillaume
Copy link
Owner

ltguillaume commented May 19, 2020

Hi, doing fine, thx! :)

The only reason I added the time to the "seen" field was to allow both the Log to display episodes seen on the same day in the proper order and to allow for the feature "Mark next episode starting from the most recently watched" (what a stupid description, come to think of it). I never thought ppl would actually find it useful to specify the actual time, but I do see your point. I have added a time picker in this build, please have a look and test for problems:
DroidShows_7.10.0.zip

If you're using F-Droid builds, it will be available in 2-3 days.

@amadeous
Copy link
Contributor Author

Wonderful! Quickly implemented!

It works for me. Should date in the messsages_edit_seen_date field in the strings be replaced for something more precise such as moment or datetime?

@ltguillaume
Copy link
Owner

If it would be a small thing to change it for all languages and if there would be a thing that would sound at least OK-ish (Edit seen timestamp?), I might have done that.

You're totally right, though, it doesn't really describe the function completely anymore.

@amadeous
Copy link
Contributor Author

Edit seen timestamp seems fine. It would be Modifier l'horodatage in french.
The string could be changed now and translated later on (when adding a potential statistics screen? 😉).

@ltguillaume
Copy link
Owner

The new release includes the changed string for some languages.

@amadeous
Copy link
Contributor Author

Splendid! I saw you changed the french translation in the french string file as well. Thank you for this new feature!

@ltguillaume
Copy link
Owner

ltguillaume commented May 29, 2020

All good! Thanks for taking the time to test it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants