Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] List of nodes associated to each custom node installed. #1157

Open
GPU-server opened this issue Oct 17, 2024 · 3 comments
Open

Comments

@GPU-server
Copy link

GPU-server commented Oct 17, 2024

It would be good if the manager was able to show the list of nodes available for every custom node installed.

(And optionally: if hovering over the node would show the name of the custom node mother).

@ltdrdata
Copy link
Owner

In what situations would this feature be useful?
And there is pack name badge already.

image

@GPU-server
Copy link
Author

GPU-server commented Oct 20, 2024

Response:
The pack name badge, does not always work. usually it is just a number # 46, # 78, # 101. I suppose it is on the custom node makers to make sure this "badging" thing work?
I would prefer if it was Comfy Manager, (or comfy), would go fetch automatically the name of the custom node and insert it on that badge area.
Of course this would be useful when loading an unknown workflow (with 100 nodes) and trying to make sens of it, but most importantly:

In what situations would this feature be useful?

The thing with loading a new workflow, and having to install missing nodes, is that I find myself having 10 custom nodes and having NO IDEA WHAT I HAVE INSTALLED.

What I want is to hover (or click) over my installed custom nodes, and find not only a "list of nodes" so I can explore them, but also the "snapshot/screenshot" of the nodes, so I can see them visually and be able to process them mentally.
For example I might "see" with my eyes, that there are 2-4 types of upscalers and see that some contain paramater/values not existing in other nodes, some allow for a slider, some always have x2 value, etc etc.

Being able to:

  1. Know the list of nodes associated to the custom nodes I have just installed
  2. SEE these nodes easily, without having to double click, write the node and display it in order to see what it look like and repeat that +40 times for all the new nodes I just acquired thought my installation of missing nodes,

seems to me to be important and useful!

@ltdrdata
Copy link
Owner

ltdrdata commented Oct 21, 2024

  1. The cases where there are only numbers are not for custom nodes.

The method previously used in ComfyUI-Manager was performed by comparing against a node list, but in the new front-end, it's done using module names, so it's represented without any omissions.
(However, it cannot represent missing nodes.)

  1. Showing a snapshot/screenshot is impossible for the Manager to do because the accurate form can only be estimated at runtime when the actual module is loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants