Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WC for computing the isotherm in charged zeolites #50

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Nov 13, 2020

This is a rebase of PR #28

@codecov-io
Copy link

codecov-io commented Nov 13, 2020

Codecov Report

Merging #50 (13f87f3) into develop (e351569) will decrease coverage by 3.03%.
The diff coverage is 3.89%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #50      +/-   ##
===========================================
- Coverage    33.66%   30.62%   -3.04%     
===========================================
  Files           25       26       +1     
  Lines         2032     2263     +231     
===========================================
+ Hits           684      693       +9     
- Misses        1348     1570     +222     
Impacted Files Coverage Δ
aiida_lsmo/workchains/zeoisotherm.py 0.00% <0.00%> (ø)
aiida_lsmo/calcfunctions/ff_builder_module.py 75.64% <90.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e351569...13f87f3. Read the comment docs.

@danieleongari danieleongari marked this pull request as draft December 16, 2020 12:06
@danieleongari
Copy link
Collaborator

COMMENT
This PR implements a work chain specifically for charged zeolites. It is first adding a stechiometric number of counter ions, then running a number of Monte Carlo NVT simulation at high temperature to locate their optimal position and later runs the GCMC calculation for the adsorbate.

After some more experience with zeolite I don't think it is a wise idea to use this work chain because the equilibrations of the ions it is something you may want to do separately and widely test before running the isotherm.
Therefore, it is maybe better to split the first part and validate the protocol and the force field versus the experimental evidence for the location of the cations (available for a few well-known topologies).

I'm not deleting this PR so that who may be interested in such a study can take inspiration from this early work.

@danieleongari danieleongari changed the title Add zeolite isotherm wc Add WC for computing the isotherm in charged zeolites Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants