Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Add panel instruction to version ESP32-4848S040 by GUITION manufactu… #556

Closed
wants to merge 2 commits into from
Closed

Conversation

FigueiredoStable
Copy link
Contributor

Added support to the board ESP32-4848S040 i buyed this board from this link:

https://pt.aliexpress.com/item/1005006335587633.html?spm=a2g0o.order_list.order_list_main.53.21efcaa4QVxg0a&gatewayAdapt=glo2bra

They have some instruction changes compared to Panel_ST7701 implemented by default.

This is a image from board:

971639B2-4FC4-41CF-A686-3E82BFD55B0F

With the default Panel_ST7701:

FD656371-C06C-403B-A00E-3FD29255FF97

Now with the Panel_ST7701_gution_esp32_4848S040:

6B443387-C58F-4529-8518-D653D0CE62EA

I don't know if is the best name to functions and the header struct, i can't finded informations to be assertive with this.

Thank you in advance for the project, I hope to be able to contribute more.

@tobozo
Copy link
Collaborator

tobozo commented Apr 23, 2024

hi, thanks for your contribution 👍

Can you please edit (or resubmit) your PR using the develop branch as base and target?

@FigueiredoStable FigueiredoStable changed the base branch from master to develop April 23, 2024 12:03
@FigueiredoStable
Copy link
Contributor Author

Hi, changed to develop.

Tks

@tobozo
Copy link
Collaborator

tobozo commented Apr 23, 2024

btw the logo on the board reads "guition", not "gution"

@FigueiredoStable
Copy link
Contributor Author

btw the logo on the board reads "guition", not "gution"

Changed to correct name, tks.

@FigueiredoStable FigueiredoStable changed the title - Add panel instruction to version ESP32-4848S040 by GUTION manufactu… - Add panel instruction to version ESP32-4848S040 by GUITION manufactu… Apr 26, 2024
@tobozo
Copy link
Collaborator

tobozo commented Apr 26, 2024

thanks 👍

this PR is still based on the master branch from your fork though, this will get some CI jobs to fail, can you please adjust it so that both source and target use the develop branch?

@FigueiredoStable
Copy link
Contributor Author

thanks 👍

this PR is still based on the master branch from your fork though, this will get some CI jobs to fail, can you please adjust it so that both source and target use the develop branch?

I seeid it now, my fork only contemply master branch (my fault) now is better close this PR and i fork from develop and submit again? i tried to update my fork with the others branchs, but i have no success.

@tobozo
Copy link
Collaborator

tobozo commented Apr 26, 2024

yep this github option to only clone the main branch is really annoying 😬 last time this happened I had to delete the fork and re-fork the project with the option checked

@FigueiredoStable
Copy link
Contributor Author

yep this github option to only clone the main branch is really annoying 😬 last time this happened I had to delete the fork and re-fork the project with the option checked

Another learning experience hehe, thankfully there are few additions that I will make again in the development field. Thank you again.

@FigueiredoStable FigueiredoStable closed this by deleting the head repository Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants