Enable stdio filesystem support #535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was commented out. Uncommenting it and adding a namespace qualifier to load_font_with_path made it work great. Tested with platformio native builds on Windows/Mingw32
.. because the corresponding platforms do not have FileWrapper
|
IDF builds are still failing. I'm trying to think of a way to enable filesystem support for native builds without making ESP-IDF choke. |
|
Okay, it passes CI now. It would be nice to say something like "#if HAS_FILE_WRAPPER" but that would require some extra work elsewhere in the code base. If this patch is accepted, what is the best way to propagate it to M5GFX ? |
|
hi and thanks for your contribution 👍 please edit your PR to use the |
|
Closing this in favor of #536 which is based on develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was commented out. Uncommenting it and adding a namespace qualifier to load_font_with_path made it work great. Tested with platformio native builds on Windows/Mingw32
I'm not sure why it was not enabled. My guess is that it failed to compile due to the missing Base:: on load_font_with_path(), and nobody had time to track down that problem.