-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arduino Compilation Issue #641
Comments
hi, Please group all feedback in this issue and close the redundant #623, as it is likely the same solution for both arduino IDE and esp-idf. LovyanGFX neither supports release versions of arduino-core (this excludes beta/alpha/RC) nor esp-idf untagged versions, however it does support Possible cause of the problem: LGFX uses the #if SOC_LCDCAM_RGB_LCD_SUPPORTED // <<<< this test fails
auto sigs = &lcd_periph_rgb_signals.panels[_cfg.port];
#else
auto sigs = &lcd_periph_signals.panels[_cfg.port];
#endif a quick solve for you only (this may break compilation for other devices/versions) is to add this after the includes in #if (ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 4, 0))
#define lcd_periph_signals lcd_periph_rgb_signals
#endif please confirm the effectiveness of that temporary workaround so I can think of a cleaner way to address the problem 😉 |
Thanks @tobozo! This resolved the issue for me however I wasn't able to straight copy & paste your patch; did you mean ESP_IDF_VERSION <= 5.4.0 and not >=? I removed the version check entirely at the expense of portability (...) and was able to compile successfully. I've added the patched [Bus_RGB.cpp] (https://gist.github.com/brodendan/b29762f0bc1aab73dc1f10cf6782509a#file-bus_rgb-cpp) file to the gist for future reference (lines 47-53). |
I meant >= 5.4.0 based on esp-idf commit where the struct changed happened. That logic was applied to a temporary branch and the CI test didn't fail so I guess that test is valid at least with esp-idf. I couldn't test with the 3.1.0-RC2 from the arduino repo though, the idf package has an invalid sha sum and arduino-cli rejects it. However as you can see in the error message the arduino-esp32 core is using idf 5.3 so in that situation it should still be using the old |
Thanks for your help! Let me know if you want any further information about my setup and I'd be happy to provide. |
happy to help! can you confirm that you don't get any error when using this branch? https://github.com/lovyan03/LovyanGFX/blob/bus-s3-rgb/ if so I'll patch the develop branch so that it'll be ready when esp-idf 5.4 is tagged by espressif |
Hi @tobozo, confirming this branch worked for me! I removed the old Lovyan library from my machine, downloaded ZIP of your linked repo and installed it as an Arduino library. Successfully compiled the sketch using this branch with no hassle. Thank you once again! |
Carefully written Issues are more likely to be given priority.
丁寧に記述された報告は優先して対応される可能性が高くなります。
Environment ( 実行環境 )
Problem Description ( 問題の内容 )
Unable to compile any Arduino sketch using the LovyanGFX library. Output throws an error related to 'lcd_periph_signals' not being declared in scope (please refer below). I have supplied manufacturer example of Lovyan usage for analysis.
Expected Behavior ( 期待される動作 )
Successful compilation.
Actual Behavior ( 実際の動作 )
Error message relating to 'lcd_periph_signals' declaration as below:
The complete output is found here: https://gist.github.com/brodendan/b29762f0bc1aab73dc1f10cf6782509a#file-error-output
Steps to reproduce ( 再現のための前提条件 )
// If possible, attach a picture of your setup/wiring here.
This is unmodified unit from Makerlabs: https://www.makerfabs.com/esp32-s3-parallel-tft-with-touch-7-inch.html
Code to reproduce this issue ( 再現させるためのコード )
Please refer to: https://gist.github.com/brodendan/b29762f0bc1aab73dc1f10cf6782509a
The text was updated successfully, but these errors were encountered: