You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a request (with or without raise_error) results in a timeout (or another error raised at the adapter level), it is impossible (as far as I know) to retrieve the details of the original request (at least in a way that's compatible with all other HTTP errors).
There should be a way to tell Faraday to never raise an error resulting from a connection (i.e. this should cover all the different timeout errors, socket errors, SSL errors) and instead, in those cases, provide the error in the object returned by Connection#get/#post/etc. (Presumably alongside where the response status/body/headers would be.)
For example, right now I'm developing unit tests for a place we use faraday and I'm realizing there's no easy way to recover information about the request that threw an error if a ruby exception was thrown.
The text was updated successfully, but these errors were encountered:
When a request (with or without
raise_error
) results in a timeout (or another error raised at the adapter level), it is impossible (as far as I know) to retrieve the details of the original request (at least in a way that's compatible with all other HTTP errors).There should be a way to tell Faraday to never raise an error resulting from a connection (i.e. this should cover all the different timeout errors, socket errors, SSL errors) and instead, in those cases, provide the error in the object returned by
Connection#get
/#post
/etc. (Presumably alongside where the response status/body/headers would be.)For example, right now I'm developing unit tests for a place we use
faraday
and I'm realizing there's no easy way to recover information about the request that threw an error if a ruby exception was thrown.The text was updated successfully, but these errors were encountered: