Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using regexps for searching for links in vpngate html page faster #1

Open
lordvidex opened this issue Jul 23, 2023 · 0 comments
Open

Consider using regexps for searching for links in vpngate html page faster #1

lordvidex opened this issue Jul 23, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@lordvidex
Copy link
Owner

lordvidex commented Jul 23, 2023 •
edited
Loading

Current Implementation

The current link finder parses the html page by looking for links, scanning each of the character and the time complexity of this is about O(MN) where M is the size of the html page and N is the size of the link pattern.

Proposal

It is possible that regexp compilation and usage might be faster since the html files are very large.

Notes

  • There is a need to benchmark the solution and compare with the current implementation
@lordvidex lordvidex added the good first issue Good for newcomers label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lordvidex