Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image does not match changes for MODE env variable #13

Open
bizrad opened this issue Aug 6, 2024 · 2 comments
Open

Docker image does not match changes for MODE env variable #13

bizrad opened this issue Aug 6, 2024 · 2 comments

Comments

@bizrad
Copy link

bizrad commented Aug 6, 2024

The #7 introduced new test modes, but the docker image yasker/kbench:latest appears to not have been updated to contain the same changes from this MR.

Please update the docker image so that the new environment variables work.

Setting this does not enable quick mode with the current deployment yaml https://github.com/longhorn/kbench/blob/main/deploy/fio.yaml

        env:
        - name: MODE
          value: "quick" # for debugging
@bizrad
Copy link
Author

bizrad commented Aug 6, 2024

Since the dockerhub image is 2 years old I just decided to fork and make my own build to get things working for me.

Here are the files if anyone else is interested:
Multi-stage Dockerfile
GitHub Docker build action

Docker image:
ghcr.io/bizrad/kbench:main@sha256:87e20d760f536a0dbdb46f1df50099cd920a0afa59aaa0b8089d3d73032bae93

@derekbit
Copy link
Member

derekbit commented Aug 6, 2024

cc @PhanLe1010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants