Remove deprecated SSL settings #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
This commit marks SSL settings `obsolete` that were previously marked as `deprecated` as part of the SSL Settings Standardization process implemented in `3.7.0` of this plugin. Marking these settings as `obsolete` is a *breaking change* that will stop the plugin from starting, and forces users to move to the new standard settings. This commit makes the following configuration settings obsolete: This commit cleans up some code to handle duplicate settings, and removes tests that were put in place to support the co-existence of deprecated and non-deprecated settings, replacing them with tests that verify that obsolete settings are identified early, and information about the deprecation is related to the user.
robbavey
force-pushed
the
obsolete_ssl
branch
from
cadfb01
to
638b294
Compare
6 tasks
donoghuc
reviewed
Nov 27, 2024
| # The maximum TLS version allowed for the encrypted connections. The value must be the one of the following: | ||
| # 1.0 for TLS 1.0, 1.1 for TLS 1.1, 1.2 for TLS 1.2, 1.3 for TLS 1.3 | ||
| config :tls_max_version, :validate => :number, :default => TLS.max.version, :deprecated => "Set 'ssl_supported_protocols' instead." | ||
| # Obsolete Settings |
There was a problem hiding this comment.
Did we decide that doing validations on obsolete settings is potentially confusing to users. logstash-plugins/logstash-input-elasticsearch#213 (comment) (with the caveat that we still use obfuscated for sensitive data)?
donoghuc
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Removal looks clean. The only open question/suggestion is consistency on whether we validate an obsolete parameter: #182 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit marks SSL settings
obsoletethat were previously marked asdeprecatedas partof the SSL Settings Standardization process implemented in
3.7.0of this plugin.Marking these settings as
obsoleteis a breaking change that will stop the plugin from starting, and forces users to move to the new standard settings.This commit makes the following configuration settings obsolete:
This commit cleans up some code to handle duplicate settings, and removes tests that were put in place to support the co-existence of deprecated and non-deprecated settings, replacing them with tests that verify that obsolete settings are identified early, and information about the deprecation is related to the user.
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link:
Relates: #181