Add new custom-resource patching mechanism for serverless>3.39.0 #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for bucket custom resources
bentsku
approved these changes
Jun 21, 2024
dfangl
force-pushed
the
fix/bucket-custom-resource-sdk-v3
branch
from
a396be1
to
2e0eb7a
Compare
|
I also updated the version to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With 3.39.0, serverless migrated their custom resource lambedas to AWS SDK v3, which broke our patching of the
s3ForcePathStyleinto the global AWS config object.#252 explains the issue in more detail, with impact explained.
We need to adapt our patching mechanism, while still maintaining backwards compatibility with older serverless versions.
Changes