Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ci python version #55

Merged
merged 3 commits into from
Nov 20, 2024
Merged

update ci python version #55

merged 3 commits into from
Nov 20, 2024

Conversation

cloutierMat
Copy link
Contributor

@cloutierMat cloutierMat commented Nov 19, 2024 •
edited
Loading

Motivation

Boto3 no longer explicitly support python 3.7 and lower, so it seems fair to remove it from our ci and pypi package.

Also adding support for newer version of python and a workflow_dispatch to allow triggering the the ci manually.

@cloutierMat cloutierMat self-assigned this Nov 19, 2024
alexrashed
alexrashed approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! 3.7 has EOL for a long time already, so it's definitely safe to remove support on our end as well! Thanks for adding the additional new versions and the workflow dispatch trigger! 💯

@cloutierMat cloutierMat merged commit f1c2318 into master Nov 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@simonrw simonrw Awaiting requested review from simonrw

@whummer whummer Awaiting requested review from whummer

Assignees

@cloutierMat cloutierMat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cloutierMat @alexrashed