-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bird-a-Day Support #52
Conversation
I can rename UseLink if it's potentially confusing with the way hooks start with use. Also thinking more on this, maybe links to equip/use/cast/familiar/whatever should be one smarter function you can pass any $item/$familiar/$skill to, with an optional parameter for hiding said link. And possibly usable within Probably I should take the link for usable items out of this PR. |
would 100% rename useLink to something like "buffLink"; to gausie's point on discord earlier, we really do not want to have "useX" functions not be hooks because when we actually start writing contributing.md that will make it even more confusing to people. love as for the tile itself, i think this is a bit too much information for the bird tile, but i have trouble figuring out how best to address the problem, because i could see cases where people do actually want the tile to show them the "extra" enchantments (ie, weapon damage % in CS, cold res while doing the peak in an avatar path, etc). this seems like a tailor-made tooltip problem where we can tier the effects and show the "tier 1" effect first and have the others in a tooltip on hoverover of the tier 1 effect. at the end of the day i think this is fine for a first pass, i just think we should revisit this when we've made some initial tooltip stuff because this seems like a relatively easy tile to make more compact via tooltips for the extraneous enchantments. |
To the point of information overload for the tile, completely agree. Formatting the buff effects in a sensible way was starting to get to be a pretty big piece of code, so I figured I'd just put the unformatted information out there now and revisit it later. Being able to just add an effect name that when hovered over with the mouse popped up the effect description similar to how it's displayed in the skillz menu in-game would be very neat, but is probably non-trivial. |
…orick into bird-a-day-support
The formatting is a bit rough around the edges but it displays the relevant information.
Added a
UseLink
component similar toEquipLink
.Added a
HorizontalRule
component which can be used with<Hr />
, similar to html's<hr />
. It's not the first time it's been mentioned, it's nice to have an easy divider in a tile.