Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoattack handling in combat strategy behaves very, very differently to regular macros #76

Open
horrible-little-slime opened this issue Feb 26, 2023 · 1 comment

Comments

@horrible-little-slime
Copy link
Contributor

compileAutoattack has nothing in it that supports starting_macro or ActionDefaults and this is, as far as I can tell, undocumented. It also doesn't appear to have any analogues thereof.

@Kasekopf
Copy link
Member

I would say it is somewhat documented here that autoattack only includes macros from .autoattack(), and not anything that was added to the normal macro. But I agree the current autoattack handling is not very complete, especially with respect to CombatActions.

I am definitely open to adding better autoattack handling. At one point I got partly through some code that added an EngineOption to copy the result of CombatStrategy.compile onto the end of the compiled autoattack. But I got stuck on how to figure out if the autoattack has already triggered before running the CombatStrategy.compile macro again (since we would want to throw an Exception if the autoattack has already triggered but the fight is not over, probably).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants