Cockroach copy target #2070
Draft
Cockroach copy target #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+31
to
+57
| function checkAndFixOvercapStats(): void { | ||
| if (myBuffedstat($stat`Muscle`) >= 100) { | ||
| if (have($effect`Gummiheart`)) uneffect($effect`Gummiheart`); | ||
| } | ||
| if (myBuffedstat($stat`Mysticality`) >= 100) { | ||
| if (have($effect`Gummibrain`)) uneffect($effect`Gummibrain`); | ||
| } | ||
| if (myBuffedstat($stat`Moxie`) >= 100) { | ||
| if (have($effect`Gummiskin`)) uneffect($effect`Gummiskin`); | ||
| } | ||
| if ( | ||
| myBuffedstat($stat`Moxie`) >= 100 || | ||
| myBuffedstat($stat`Mysticality`) >= 100 || | ||
| myBuffedstat($stat`Muscle`) >= 100 | ||
| ) { | ||
| uneffect($effect`Having a Ball!`); | ||
| } | ||
| if ( | ||
| myBuffedstat($stat`Moxie`) >= 100 || | ||
| myBuffedstat($stat`Mysticality`) >= 100 || | ||
| myBuffedstat($stat`Muscle`) >= 100 | ||
| ) { | ||
| abort( | ||
| "Buffed stats are too high for PirateRealm! Check for equipment or buffs that we can add to prevent in the script", | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
This can be streamlined through iteration
| have($skill`Just the Facts`) && | ||
| have($skill`Meteor Lore`) && | ||
| have($item`Powerful Glove`) && | ||
| (get("_prToday") || get("prAlways")) |
There was a problem hiding this comment.
use realmAvailable
Comment on lines
+114
to
+115
| have($skill`Meteor Lore`) && | ||
| have($item`Powerful Glove`) && |
There was a problem hiding this comment.
We should have a function that essentially boils down to "how many monster replacers are available"
| @@ -107,6 +108,15 @@ function ensureBarfAccess() { | |||
| } | |||
|
|
|||
| function defaultTarget() { | |||
| // Can we account for re-entry if we only have certain amounts of copiers left in each of these? | |||
| if ( | |||
| have($skill`Just the Facts`) && | |||
There was a problem hiding this comment.
we should have a function that boils down to "do we expect to fight gregs today"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just trying to block out the structure a bit in this draft