Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifier after x turns #1084

Open
wants to merge 40 commits into
base: main
Choose a base branch
from

Conversation

quarklikeadork
Copy link
Contributor

@quarklikeadork quarklikeadork commented Mar 12, 2022

add function that gives modifierAfterXTurns
waste less soul food to restore MP that will be lost next turn from expired buffs
burn MP in pre adv if it will be lost by reduced max MP next turn
don't try to burn all MP when MP regen is huge

How Has This Been Tested?

in run. only starts being useful over 400 MP for now because pre adv doesn't burn at lower MP than that

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have based by pull request against the master branch or have a good reason not to.

Copy link
Member

@Alium58 Alium58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few clarifying questions for my own understanding

RELEASE/scripts/autoscend/auto_post_adv.ash Show resolved Hide resolved
RELEASE/scripts/autoscend/auto_post_adv.ash Show resolved Hide resolved
RELEASE/scripts/autoscend/auto_post_adv.ash Outdated Show resolved Hide resolved
@Alium58
Copy link
Member

Alium58 commented Jul 7, 2023

sorry this has been open forever. Based on comments I think this one is good to go, do you agree?

@quarklikeadork
Copy link
Contributor Author

sorry this has been open forever. Based on comments I think this one is good to go, do you agree?

Yes, I think this was for nuns, I won't be doing that but someone else can use it, and the MP saving is not bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants