Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounty hunting fixes #196

Merged
merged 28 commits into from
Nov 3, 2023
Merged

Bounty hunting fixes #196

merged 28 commits into from
Nov 3, 2023

Commits on Sep 22, 2023

  1. Bounty hunting fixes

    - switched to querying KoLmafia for bounty info, old method does not work anymore; as per KoLmafia wiki, it will return amount_needed = 0 and target_monster = none in case the bounty does not exist
    - fixed the suggestion to improve combat rate listing the current combat rate instead of the rate necessary to reach 100%
    - made it so the location will still be shown even if there is no chance to encounter the monster (e.g. it is banished). Otherwise, it looks weird ("From smut orc pipelayer in ."). -1.0 is used as infinity
    Semenar committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    63ccbb9 View commit details
    Browse the repository at this point in the history
  2. oops infinite priority

    Semenar committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    19fb989 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fa5a6c3 View commit details
    Browse the repository at this point in the history
  4. Fix combat rate calculations

    I got confused because it is named "combat rate", so needing to increase exactly by "combat rate" seems weird. But it actually was a "noncombat rate" all along. Replaced it with canonical combat_percent.
    
    There is a bug with Smut Orc Logging Camp (stuck on 0% combat sometimes), but this will need fixing in Mafia.
    Semenar committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    ba47832 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2023

  1. Pull limit code fixes

    - add a separator to the split_string function: it does not actually separate entries otherwise
    - the one-liner is nice, but it does not work because it checks keys, not values - so the only items that would ever ring true for it have IDs from 0 to 19. Fixed to check values.
    Semenar committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    481b66f View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2023

  1. Arrrbor Day fixes

    - do not propose to adventure there if already planted enough saplings
    - show turns left in the task description
    Semenar committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    c979084 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Configuration menu
    Copy the full SHA
    8a5dcf7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f9c43af View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    670e5f8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8b69606 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bf80beb View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Configuration menu
    Copy the full SHA
    d2a7aab View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Configuration menu
    Copy the full SHA
    ef67557 View commit details
    Browse the repository at this point in the history
  2. Fix the Farm NC reminder show rules

    Mafia also logs into the zone queues noncombats that are item adjustments (for example), so an explicit check is better.
    Also added a check to see if we are at the farm, to not hide the tip when on the last noncombat.
    Semenar committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    05d0bb7 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Do not offer to visit hippy store in Surprising Fist

    Meat goes to charity instead.
    Semenar committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    12b75c8 View commit details
    Browse the repository at this point in the history
  2. Do not show the scalpel as an option without hands

    Cannot equip it in Avatar of Boris and Surprising Fist.
    Semenar committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    b578e40 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    80d2353 View commit details
    Browse the repository at this point in the history
  4. Fix appearance rate calculations

    Appearance rates as returned by Mafia use a modified combat rate for noncombats, but unmodified one for combats. This caused bounty_appearance_rate to go above 1 in case only one monster is available, the place has skippable noncombats, and the player is running -combat.
    
    Also renamed base_combat_rate below into combat_rate, because the previous name is misleading.
    Semenar committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    36b26a9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b96f2b5 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Fix the Road to White Citadel availability condition

    Is closed upon unlocking the White Citadel.
    Semenar committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    eb5d160 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2023

  1. Configuration menu
    Copy the full SHA
    71740ac View commit details
    Browse the repository at this point in the history
  2. oops fix the color

    Semenar committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    8d9d101 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Configuration menu
    Copy the full SHA
    6fe6fc6 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Zero exists

    int_to_cardinal returned "" as 0 before, which resulted in such masterpieces as "seal screeches" instead of "Zero seal screeches".
    Semenar committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    e300d57 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Configuration menu
    Copy the full SHA
    3bd59ca View commit details
    Browse the repository at this point in the history
  2. Gingerbread fix by Scotch

    Semenar committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    6829e18 View commit details
    Browse the repository at this point in the history
  3. very small priority tweak

    docrostov committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f514fe6 View commit details
    Browse the repository at this point in the history
  4. Do not show Fifty Ways for the sleaze race if other wish suggestions …

    …for Zeppelin are displayed
    Semenar committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    bd04e32 View commit details
    Browse the repository at this point in the history