Bounty hunting fixes #196
Merged
Bounty hunting fixes #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Semenar
commented
Sep 22, 2023
Semenar
commented
- switched to querying KoLmafia for bounty info, old method does not work anymore; as per KoLmafia wiki, it will return amount_needed = 0 and target_monster = none in case the bounty does not exist
- fixed the suggestion to improve combat rate listing the current combat rate instead of the rate necessary to reach 100%
- made it so the location will still be shown even if there is no chance to encounter the monster (e.g. it is banished). Otherwise, it looks weird ("From smut orc pipelayer in ."). -1.0 is used as infinity
- switched to querying KoLmafia for bounty info, old method does not work anymore; as per KoLmafia wiki, it will return amount_needed = 0 and target_monster = none in case the bounty does not exist
- fixed the suggestion to improve combat rate listing the current combat rate instead of the rate necessary to reach 100%
- made it so the location will still be shown even if there is no chance to encounter the monster (e.g. it is banished). Otherwise, it looks weird ("From smut orc pipelayer in ."). -1.0 is used as infinity
I got confused because it is named "combat rate", so needing to increase exactly by "combat rate" seems weird. But it actually was a "noncombat rate" all along. Replaced it with canonical combat_percent. There is a bug with Smut Orc Logging Camp (stuck on 0% combat sometimes), but this will need fixing in Mafia.
- add a separator to the split_string function: it does not actually separate entries otherwise - the one-liner is nice, but it does not work because it checks keys, not values - so the only items that would ever ring true for it have IDs from 0 to 19. Fixed to check values.
- do not propose to adventure there if already planted enough saplings - show turns left in the task description
Mafia also logs into the zone queues noncombats that are item adjustments (for example), so an explicit check is better. Also added a check to see if we are at the farm, to not hide the tip when on the last noncombat.
Meat goes to charity instead.
Cannot equip it in Avatar of Boris and Surprising Fist.
Appearance rates as returned by Mafia use a modified combat rate for noncombats, but unmodified one for combats. This caused bounty_appearance_rate to go above 1 in case only one monster is available, the place has skippable noncombats, and the player is running -combat. Also renamed base_combat_rate below into combat_rate, because the previous name is misleading.
Is closed upon unlocking the White Citadel.
int_to_cardinal returned "" as 0 before, which resulted in such masterpieces as "seal screeches" instead of "Zero seal screeches".
docrostov
requested changes
Nov 2, 2023
|
|
||
| string [int] options; | ||
| string [int] description; | ||
| description.listAppend("Pick a pocket for something useful! Too many to list!"); | ||
| if (__misc_state["in run"] && my_path().id != PATH_COMMUNITY_SERVICE) | ||
| { | ||
| if (locationAvailable($location[The royal guard Chamber]) == true) | ||
| if (locationAvailable($location[The royal guard Chamber]) == true && !(empty_pockets contains 343)) |
There was a problem hiding this comment.
i am assuming you've checked this tweak operates correctly? part of me thinks that given how you factored this, instead of doing a contains logic like this, you should just do && !empty_pockets[343] because it's slightly more fitting. i think the syntax you have here works but that feels slightly cleaner to me.
There was a problem hiding this comment.
Yes, I checked that this works.
…for Zeppelin are displayed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.