Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/Models /using_openvino_models.py -> "Directory missing" error #1104

Open
andytolle opened this issue Nov 12, 2024 · 2 comments
Open

Comments

@andytolle
Copy link

To replicate the error:

  • On windows (10 or 11): Delete "c:\users<user>\llmware_data\model_repo" directory
  • Run the openvino example "examples/Models /using_openvino_models.py"
  • Notice how the example doesn't run: The user gets an error (saying that something is missing: this directory).

The user needs to then first manually create the directory. Then the example runs fine.

A quick fix is either

  • Check for the directory and create it, if it doesn't exist (would probably be nice to do it in the library)
  • or catching and interpreting the error in the example and programmatically create the directory if needed
@doberst
Copy link
Contributor

doberst commented Nov 12, 2024

@andytolle - great catch - and yes, this is a bug - missing defensive code in a path specific to loading the external tokenizer used with OpenVINO models (if this is first use of llmware). Will be fixed later today. Appreciate you sharing this.... keep the feedback coming! :). kind regards - Darren

@doberst
Copy link
Contributor

doberst commented Nov 12, 2024

@andytolle - thanks again for catching this - the fix has been merged in the main branch. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants