Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: SPF fail types in reports & summaries #144

Open
ShawnPConroy opened this issue Oct 26, 2024 · 2 comments
Open

Feature Request: SPF fail types in reports & summaries #144

ShawnPConroy opened this issue Oct 26, 2024 · 2 comments

Comments

@ShawnPConroy
Copy link
Contributor

Back a few years ago I created a script that worked very much like this one. But I realize now that the way SPF errors are shown are not as insightful as they could be.

In summaries and reports, it would be very useful to distinguish between softfails and hardfails, with a plus similar to how you distinguish between quarantines and rejections. In some situations, softfails are acceptable, and conflating them or colouring them red is not great.

Along with breaking out soft and hard SPF fails "x+y", I'd recommend a change to the colours. Basically, all reds except rejections should change to oranges. Except SPF softfails, which should be yellow.

Incoming Reports:

SPF softfail: yellow
SPF hardfail: orange
SPF pass: green
DKIM pass: green
DKIM fail: orange
Disposition none: green
Disposition quarantine: orange
Disposition reject: red (or orange)
Quarantined: orange
Rejected: red

Summary

SPF softfail: yellow
PSF hardfail: orange
DKIM fail: orange
Not aligned: orange
Disposition quarantine: orange
Disposition reject: red (or orange)
Fail rate (red)

Here are some possible text colours with links I've put on white or the dark mode background (--color-bg-default) you use so you can see how it looks.

Light:

Dark:

@liuch
Copy link
Owner

liuch commented Oct 27, 2024

I guess I agree with your suggestion about the color scheme. The red color in the alignment column was used because the disposition was not displayed before. As for a separate color for softfail, I need to think about how to implement that. I don't see a simple solution yet.

Another thing I have a question about: how do you distinguish between reject disposition and rejected?

@ShawnPConroy
Copy link
Contributor Author

how do you distinguish between reject disposition and rejected?

I listed those as they are used in the incoming report view. I don't think there is a difference, and assume there isn't in what the code does. I did optionally list orange for one to reduce the amount of red. Leaving red only once per row and only in the final column to reduce visual noise and be the most eye catching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants