From b55b65300eecc7e8eeaaedb1b5c2079d4613e90c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oliver=20K=C3=A4stner?= Date: Sun, 31 Mar 2024 23:05:23 +0200 Subject: [PATCH 1/2] network/mobile: remove serial config This is based on assumptions and is unnecessary for most modems. For almost a decade, the NM applet has not done this, see: https://gitlab.gnome.org/GNOME/network-manager-applet/-/commit/604d7db2ca49a44fb095c787793ba3afcb50fdd9 --- panels/network/network-dialogs.c | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/panels/network/network-dialogs.c b/panels/network/network-dialogs.c index 2e32c6ea..ed8ad7c5 100644 --- a/panels/network/network-dialogs.c +++ b/panels/network/network-dialogs.c @@ -337,16 +337,6 @@ cdma_mobile_wizard_done (NMAMobileWizard *wizard, NULL); nm_connection_add_setting (connection, setting); - /* Serial setting */ - setting = nm_setting_serial_new (); - g_object_set (setting, - NM_SETTING_SERIAL_BAUD, 115200, - NM_SETTING_SERIAL_BITS, 8, - NM_SETTING_SERIAL_PARITY, 'n', - NM_SETTING_SERIAL_STOPBITS, 1, - NULL); - nm_connection_add_setting (connection, setting); - nm_connection_add_setting (connection, nm_setting_ppp_new ()); setting = nm_setting_connection_new (); @@ -400,16 +390,6 @@ gsm_mobile_wizard_done (NMAMobileWizard *wizard, NULL); nm_connection_add_setting (connection, setting); - /* Serial setting */ - setting = nm_setting_serial_new (); - g_object_set (setting, - NM_SETTING_SERIAL_BAUD, 115200, - NM_SETTING_SERIAL_BITS, 8, - NM_SETTING_SERIAL_PARITY, 'n', - NM_SETTING_SERIAL_STOPBITS, 1, - NULL); - nm_connection_add_setting (connection, setting); - nm_connection_add_setting (connection, nm_setting_ppp_new ()); setting = nm_setting_connection_new (); From df0f185341271b552d5de521604af1e984730319 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oliver=20K=C3=A4stner?= Date: Sun, 31 Mar 2024 23:40:29 +0200 Subject: [PATCH 2/2] network/mobile: allow dual stack cellular connections Copied from: https://gitlab.gnome.org/GNOME/network-manager-applet/-/commit/6701ae6fece2ec8f8597ea837d890fdbfe82aadc --- panels/network/network-dialogs.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/panels/network/network-dialogs.c b/panels/network/network-dialogs.c index ed8ad7c5..a46ba8b3 100644 --- a/panels/network/network-dialogs.c +++ b/panels/network/network-dialogs.c @@ -337,6 +337,15 @@ cdma_mobile_wizard_done (NMAMobileWizard *wizard, NULL); nm_connection_add_setting (connection, setting); + /* Default to IPv4 & IPv6 'automatic' addressing */ + setting = nm_setting_ip4_config_new (); + g_object_set (setting, NM_SETTING_IP_CONFIG_METHOD, NM_SETTING_IP4_CONFIG_METHOD_AUTO, NULL); + nm_connection_add_setting (connection, setting); + + setting = nm_setting_ip6_config_new (); + g_object_set (setting, NM_SETTING_IP_CONFIG_METHOD, NM_SETTING_IP6_CONFIG_METHOD_AUTO, NULL); + nm_connection_add_setting (connection, setting); + nm_connection_add_setting (connection, nm_setting_ppp_new ()); setting = nm_setting_connection_new (); @@ -390,6 +399,15 @@ gsm_mobile_wizard_done (NMAMobileWizard *wizard, NULL); nm_connection_add_setting (connection, setting); + /* Default to IPv4 & IPv6 'automatic' addressing */ + setting = nm_setting_ip4_config_new (); + g_object_set (setting, NM_SETTING_IP_CONFIG_METHOD, NM_SETTING_IP4_CONFIG_METHOD_AUTO, NULL); + nm_connection_add_setting (connection, setting); + + setting = nm_setting_ip6_config_new (); + g_object_set (setting, NM_SETTING_IP_CONFIG_METHOD, NM_SETTING_IP6_CONFIG_METHOD_AUTO, NULL); + nm_connection_add_setting (connection, setting); + nm_connection_add_setting (connection, nm_setting_ppp_new ()); setting = nm_setting_connection_new ();