Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate inconsistency between sncosmo and our band fluxes #133

Open
hombit opened this issue Sep 26, 2024 · 0 comments
Open

Investigate inconsistency between sncosmo and our band fluxes #133

hombit opened this issue Sep 26, 2024 · 0 comments

Comments

@hombit
Copy link
Contributor

hombit commented Sep 26, 2024

Updated in PR 132 SN Ia end2end test and notebooks show small but significant few percent inconsistency between our band fluxes and their. The problem is especially bad when negative flux densities are presented.

I'm not sure what is the root or the problem, some possible options:

  • Difference between trapezoid integration we use and rectangle integration sncosmo uses
  • Difference in interpolation
  • Some problems in our band integration code
  • Some problems in our redshift code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant