Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer compiles for Lift 2.6 #19

Open
d6y opened this issue Apr 6, 2015 · 3 comments
Open

No longer compiles for Lift 2.6 #19

d6y opened this issue Apr 6, 2015 · 3 comments

Comments

@d6y
Copy link
Member

d6y commented Apr 6, 2015

The widgets source code is no longer compatible with Lift 2.6. I don't think this is a problem. I propose to modify the build.sbt to specify Lift 3.0-SNAPSHOT.

When compiling with Lift 2.6 the error is:

[info] Compiling 25 Scala sources to /Users/richard/Developer/lift/modules/widgets/target/scala-2.11/classes...
[error] /Users/richard/Developer/lift/modules/widgets/src/main/scala/net/liftmodules/widgets/autocomplete/AutoComplete.scala:181: value liftPath is not a member of object net.liftweb.http.LiftRules
[error]       val what: String = encodeURL(S.contextPath + "/" + LiftRules.liftPath + "/ajax/"+ S.renderVersion+"?"+func+"=foo")
[error]                                                                    ^

and

[error] /Users/richard/Developer/lift/modules/widgets/src/main/scala/net/liftmodules/widgets/tree/TreeView.scala:120: value liftPath is not a member of object net.liftweb.http.LiftRules
[error]              "/"+LiftRules.liftPath + "/ajax/"+ S.renderVersion)+"?"+key+"=_"
[error]                            ^
[warn] three warnings found
[error] two errors found

There are also deprecation warnings about deprecations to @deprecations. Which is my all time favourite deprecation.

@Shadowfiend
Copy link

Lol. Certainly if we're referencing liftPath it seems like the snapshot should be for 3.0-SNAPSHOT, yeah.

@fmpwizard
Copy link
Member

I haven't checked if this is already the case, but I would say do a build for lift 2.6 scala 2.11 and then bump the widgets to 1.4-SNAPSHOT and have it only build for 2.11 and lift 3.0-SNAPSHOT

@d6y
Copy link
Member Author

d6y commented Apr 7, 2015

It looks like I didn't publish 2.6 (non-snapshot) versions of the modules when 2.6 came out. So I'll do that before anything else; and then bump the version number up and switch to 3.0-SNAPSHOT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants