Add plug point for treating arguments as locals #315

frabert · 2023-01-04T09:54:34Z

Also additional method for changing variable type for allocas

github-actions · 2023-01-04T09:58:13Z

See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/3836932737

fizzbuzz.bc

--- /dev/fd/63	2023-01-04 09:58:05.445872322 +0000
+++ /dev/fd/62	2023-01-04 09:58:05.445872322 +0000
@@ -11,15 +11,14 @@
     var1 = 0U;
     while ((int)var1 < 30)
         {
-            if ((int)var1 % 3 != 0U || !((int)var1 % 5 == 0U || (int)var1 % 3 != 0U)) {
-                if ((int)var1 % 3 != 0U && ((int)var1 % 3 != 0U || (int)var1 % 5 != 0U)) {
+            if (!((int)var1 % 3 != 0U || (int)var1 % 5 == 0U) || (int)var1 % 3 != 0U) {
+                if ((int)var1 % 3 != 0U) {
                     if ((int)var1 % 5 != 0U) {
                         printf("%d\n", var1);
                     } else {
                         printf("buzz\n");
                     }
-                }
-                if ((int)var1 % 3 == 0U && ((int)var1 % 3 != 0U || (int)var1 % 5 != 0U)) {
+                } else {
                     printf("fizz\n");
                 }
             } else {

typedefs_of_typedefs.bc

switch_loop.bc

func_cond_zero_arg.bc

fcmp.bc

conflicting_names.bc

struct.bc

issue_183_literal_structs.bc

zeroinit.bc

struct_swap.bc

init_list.bc

ret0.bc

bool.bc

bitops.bc

cast.bc

nullptr.bc

conflicting_global.bc

array_swap.bc

bitmask.bc

binops.bc

float.bc

reg_test_structure_fields.bc

vectors.bc

funcptr.bc

goto_loop.bc

short.bc

trunc.bc

inttoptr.bc

issue_4.bc

issue_127_uint128_t_lit.bc

issue_123_uint128_t.bc

fizzbuzz_stateful.bc

issue_94_strncmp.bc

nested_struct.bc

global_using_function_decl.bc

byval_struct.bc

nested_while.bc

func_cond_two_arg.bc

zext.bc

assert.bc

loop.bc

switch.bc

branch.bc

template_parameter_pack.bc

byval_tail_nogep.ll

byval_tail_gep.ll

github-actions · 2023-01-23T15:07:14Z

See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/3987629702

fizzbuzz.bc

typedefs_of_typedefs.bc

switch_loop.bc

func_cond_zero_arg.bc

fcmp.bc

conflicting_names.bc

struct.bc

issue_183_literal_structs.bc

zeroinit.bc

global_using_function_decl.bc

init_list.bc

ret0.bc

goto_loop.bc

bool.bc

bitops.bc

cast.bc

nullptr.bc

conflicting_global.bc

array_swap.bc

bitmask.bc

binops.bc

float.bc

reg_test_structure_fields.bc

vectors.bc

funcptr.bc

struct_swap.bc

short.bc

trunc.bc

inttoptr.bc

issue_4.bc

issue_127_uint128_t_lit.bc

issue_123_uint128_t.bc

fizzbuzz_stateful.bc

issue_94_strncmp.bc

nested_struct.bc

zext.bc

byval_struct.bc

nested_while.bc

--- /dev/fd/63	2023-01-23 15:07:11.963468951 +0000
+++ /dev/fd/62	2023-01-23 15:07:11.963468951 +0000
@@ -25,7 +25,7 @@
                 printf("loop2 x: %d\n", var1);
             }
     }
-    if (((int)var1 >= 20 || (int)var1 <= 10) && (int)var1 >= 20) {
+    if ((int)var1 >= 20 && ((int)var1 >= 20 || (int)var1 <= 10)) {
         return var0;
     }
 }

func_cond_two_arg.bc

assert.bc

loop.bc

switch.bc

branch.bc

template_parameter_pack.bc

byval_tail_gep.ll

byval_tail_nogep.ll

github-actions · 2023-01-25T14:54:38Z

See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/4007072893

fizzbuzz.bc

typedefs_of_typedefs.bc

switch_loop.bc

func_cond_zero_arg.bc

fcmp.bc

conflicting_names.bc

struct.bc

issue_183_literal_structs.bc

zeroinit.bc

global_using_function_decl.bc

init_list.bc

ret0.bc

goto_loop.bc

bool.bc

bitops.bc

cast.bc

nullptr.bc

conflicting_global.bc

array_swap.bc

bitmask.bc

binops.bc

float.bc

reg_test_structure_fields.bc

vectors.bc

funcptr.bc

struct_swap.bc

short.bc

trunc.bc

inttoptr.bc

issue_4.bc

issue_127_uint128_t_lit.bc

issue_123_uint128_t.bc

fizzbuzz_stateful.bc

issue_94_strncmp.bc

nested_struct.bc

zext.bc

byval_struct.bc

nested_while.bc

func_cond_two_arg.bc

assert.bc

loop.bc

switch.bc

branch.bc

template_parameter_pack.bc

byval_tail_gep.ll

byval_tail_nogep.ll

github-actions · 2023-01-26T13:04:57Z

See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/4015340181

fizzbuzz.bc

typedefs_of_typedefs.bc

switch_loop.bc

func_cond_zero_arg.bc

fcmp.bc

conflicting_names.bc

struct.bc

issue_183_literal_structs.bc

zeroinit.bc

global_using_function_decl.bc

init_list.bc

ret0.bc

goto_loop.bc

bool.bc

bitops.bc

cast.bc

nullptr.bc

conflicting_global.bc

array_swap.bc

bitmask.bc

binops.bc

float.bc

reg_test_structure_fields.bc

vectors.bc

funcptr.bc

struct_swap.bc

short.bc

trunc.bc

inttoptr.bc

issue_4.bc

issue_127_uint128_t_lit.bc

issue_123_uint128_t.bc

fizzbuzz_stateful.bc

issue_94_strncmp.bc

nested_struct.bc

zext.bc

byval_struct.bc

nested_while.bc

--- /dev/fd/63	2023-01-26 13:04:54.503194856 +0000
+++ /dev/fd/62	2023-01-26 13:04:54.503194856 +0000
@@ -25,7 +25,7 @@
                 printf("loop2 x: %d\n", var1);
             }
     }
-    if (((int)var1 >= 20 || (int)var1 <= 10) && (int)var1 >= 20) {
+    if ((int)var1 >= 20 && ((int)var1 >= 20 || (int)var1 <= 10)) {
         return var0;
     }
 }

func_cond_two_arg.bc

assert.bc

loop.bc

switch.bc

branch.bc

template_parameter_pack.bc

byval_tail_gep.ll

byval_tail_nogep.ll

github-actions · 2023-01-26T13:14:52Z

See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/4015452164

fizzbuzz.bc

typedefs_of_typedefs.bc

switch_loop.bc

func_cond_zero_arg.bc

fcmp.bc

conflicting_names.bc

struct.bc

issue_183_literal_structs.bc

zeroinit.bc

global_using_function_decl.bc

init_list.bc

ret0.bc

goto_loop.bc

bool.bc

bitops.bc

cast.bc

nullptr.bc

conflicting_global.bc

array_swap.bc

bitmask.bc

binops.bc

float.bc

reg_test_structure_fields.bc

vectors.bc

funcptr.bc

struct_swap.bc

short.bc

trunc.bc

inttoptr.bc

issue_4.bc

issue_127_uint128_t_lit.bc

issue_123_uint128_t.bc

fizzbuzz_stateful.bc

issue_94_strncmp.bc

nested_struct.bc

zext.bc

byval_struct.bc

nested_while.bc

func_cond_two_arg.bc

assert.bc

loop.bc

switch.bc

branch.bc

template_parameter_pack.bc

byval_tail_gep.ll

byval_tail_nogep.ll

github-actions · 2023-02-06T17:11:09Z

See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/4105996780

fizzbuzz.bc

typedefs_of_typedefs.bc

switch_loop.bc

func_cond_zero_arg.bc

fcmp.bc

conflicting_names.bc

struct.bc

issue_183_literal_structs.bc

zeroinit.bc

global_using_function_decl.bc

init_list.bc

ret0.bc

goto_loop.bc

bool.bc

bitops.bc

cast.bc

nullptr.bc

conflicting_global.bc

array_swap.bc

bitmask.bc

binops.bc

float.bc

reg_test_structure_fields.bc

vectors.bc

funcptr.bc

struct_swap.bc

short.bc

trunc.bc

inttoptr.bc

issue_4.bc

issue_127_uint128_t_lit.bc

issue_123_uint128_t.bc

fizzbuzz_stateful.bc

issue_94_strncmp.bc

nested_struct.bc

zext.bc

byval_struct.bc

nested_while.bc

--- /dev/fd/63	2023-02-06 17:11:06.315041757 +0000
+++ /dev/fd/62	2023-02-06 17:11:06.315041757 +0000
@@ -25,7 +25,7 @@
                 printf("loop2 x: %d\n", var1);
             }
     }
-    if ((int)var1 >= 20 && ((int)var1 >= 20 || (int)var1 <= 10)) {
+    if (((int)var1 >= 20 || (int)var1 <= 10) && (int)var1 >= 20) {
         return var0;
     }
 }

func_cond_two_arg.bc

assert.bc

loop.bc

switch.bc

branch.bc

template_parameter_pack.bc

byval_tail_gep.ll

byval_tail_nogep.ll

github-actions · 2023-02-22T16:40:43Z

See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/4244868052

fizzbuzz.bc

typedefs_of_typedefs.bc

switch_loop.bc

func_cond_zero_arg.bc

conflicting_names.bc

struct.bc

issue_183_literal_structs.bc

struct_swap.bc

short.bc

init_list.bc

ret0.bc

goto_loop.bc

bool.bc

bitops.bc

cast.bc

nullptr.bc

nested_struct.bc

array_swap.bc

bitmask.bc

binops.bc

float.bc

reg_test_structure_fields.bc

zeroinit.bc

conflicting_global.bc

inttoptr.bc

branch.bc

funcptr.bc

trunc.bc

vectors.bc

issue_4.bc

issue_127_uint128_t_lit.bc

issue_123_uint128_t.bc

fizzbuzz_stateful.bc

issue_94_strncmp.bc

global_using_function_decl.bc

fcmp.bc

byval_struct.bc

nested_while.bc

func_cond_two_arg.bc

zext.bc

assert.bc

loop.bc

switch.bc

template_parameter_pack.bc

byval_tail_nogep.ll

byval_tail_gep.ll

* use zero for undef floats * fix format

github-actions · 2023-07-06T13:10:17Z

See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/5475823810

fizzbuzz.bc

typedefs_of_typedefs.bc

switch_loop.bc

func_cond_zero_arg.bc

fcmp.bc

conflicting_names.bc

struct.bc

issue_183_literal_structs.bc

init_list.bc

ret0.bc

goto_loop.bc

bool.bc

short.bc

cast.bc

nullptr.bc

conflicting_global.bc

array_swap.bc

bitmask.bc

binops.bc

float.bc

reg_test_structure_fields.bc

nested_while.bc

zeroinit.bc

funcptr.bc

struct_swap.bc

branch.bc

vectors.bc

bitops.bc

trunc.bc

inttoptr.bc

issue_4.bc

issue_127_uint128_t_lit.bc

issue_123_uint128_t.bc

fizzbuzz_stateful.bc

issue_94_strncmp.bc

nested_struct.bc

global_using_function_decl.bc

byval_struct.bc

func_cond_two_arg.bc

zext.bc

assert.bc

loop.bc

switch.bc

template_parameter_pack.bc

byval_tail_nogep.ll

byval_tail_gep.ll

* llvm 17 fixes * Update CI --------- Co-authored-by: Francesco Bertolaccini <francesco.bertolaccini@trailofbits.com>

frabert marked this pull request as draft January 23, 2023 15:00

frabert force-pushed the frabert/pluggable-vars branch from 4efc2a9 to a78a14a Compare January 25, 2023 14:50

frabert force-pushed the frabert/pluggable-vars branch from 760985f to 5a342a1 Compare February 22, 2023 16:35

frabert added 9 commits May 31, 2023 10:36

Interface for choosing local variable types

9caed27

Allow users to make arguments appear as locals

744b602

Fix number of arguments in generated functions

cb34c4c

Refactor interface

97ca11b

Allow type generation in arbitrary decl contexts

9ef3bcf

Fix tests

30194f3

Generate decl statements for all decls

842ae7e

Ignore struct decls without type info

60f92c2

Move more logic into the function layout override

a86c8b7

frabert force-pushed the frabert/pluggable-vars branch from 5a342a1 to a86c8b7 Compare May 31, 2023 13:14

Replace undef constant floats with 0 (#328)

f282426

* use zero for undef floats * fix format

2over12 and others added 2 commits October 6, 2023 17:51

llvm 17 fixes (#330)

1961ac5

* llvm 17 fixes * Update CI --------- Co-authored-by: Francesco Bertolaccini <francesco.bertolaccini@trailofbits.com>

Merge branch 'master' into frabert/pluggable-vars

8392e59

Add plug point for treating arguments as locals #315

Are you sure you want to change the base?

Add plug point for treating arguments as locals #315

Conversation

frabert commented Jan 4, 2023 • edited Loading

github-actions bot commented Jan 4, 2023

fizzbuzz.bc

typedefs_of_typedefs.bc

switch_loop.bc

func_cond_zero_arg.bc

fcmp.bc

conflicting_names.bc

struct.bc

issue_183_literal_structs.bc

zeroinit.bc

struct_swap.bc

init_list.bc

ret0.bc

bool.bc

bitops.bc

cast.bc

nullptr.bc

conflicting_global.bc

array_swap.bc

bitmask.bc

binops.bc

float.bc

reg_test_structure_fields.bc

vectors.bc

funcptr.bc

goto_loop.bc

short.bc

trunc.bc

inttoptr.bc

issue_4.bc

issue_127_uint128_t_lit.bc

issue_123_uint128_t.bc

fizzbuzz_stateful.bc

issue_94_strncmp.bc

nested_struct.bc

global_using_function_decl.bc

byval_struct.bc

nested_while.bc

func_cond_two_arg.bc

zext.bc

assert.bc

loop.bc

switch.bc

branch.bc

template_parameter_pack.bc

byval_tail_nogep.ll

byval_tail_gep.ll

github-actions bot commented Jan 23, 2023

fizzbuzz.bc

typedefs_of_typedefs.bc

switch_loop.bc

func_cond_zero_arg.bc

fcmp.bc

conflicting_names.bc

struct.bc

issue_183_literal_structs.bc

zeroinit.bc

global_using_function_decl.bc

init_list.bc

ret0.bc

goto_loop.bc

bool.bc

bitops.bc

cast.bc

nullptr.bc

conflicting_global.bc

array_swap.bc

bitmask.bc

binops.bc

float.bc

reg_test_structure_fields.bc

vectors.bc

funcptr.bc

struct_swap.bc

short.bc

frabert commented Jan 4, 2023 •

edited

Loading