Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

average_onto_vertices only accepts 3-dim input #225

Open
Sentient07 opened this issue Feb 19, 2024 · 2 comments · May be fixed by #243
Open

average_onto_vertices only accepts 3-dim input #225

Sentient07 opened this issue Feb 19, 2024 · 2 comments · May be fixed by #243

Comments

@Sentient07
Copy link

Hi,

As far as I understand, this function: https://libigl.github.io/libigl-python-bindings/igl_docs/#average_onto_vertices would be performing a matrix (incidence with voronoi weight?) vector multiplication. I don't understand why it's restricted to 3-dim input? It's not very clear from the doc, but when I would try a 4-dim input, I get the error, ValueError: Parameter s has invalid shape, expected s.shape = [13776, 3] but got s.shape = [13776, 4]

Shouldn't it accept any k-dim vector?

Thank you!

@alecjacobson
Copy link
Contributor

Seems to be a bug here:

assert_shape_equals(s, f.rows(), v.cols(), "s");

Happy to merge a PR

@Sentient07
Copy link
Author

Thank you! I'll try to send one soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants