Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More unit tests? #12

Open
Hedda opened this issue Apr 10, 2024 · 0 comments
Open

More unit tests? #12

Hedda opened this issue Apr 10, 2024 · 0 comments

Comments

@Hedda
Copy link
Contributor

Hedda commented Apr 10, 2024

@lhespress Do you plan on writting additonal unit tests in this radio library for zigpy?

For reference please see the tests directory for the bellows, zigpy-znp, and zigpy-deconz radio libraries and add minimum:

puddly's reply in home-assistant/core#114828 indicates lack of unit tests in radio library can be a showstopper for acceptance.

"Merging support for an untested package would introduce an enormous maintenance burden, as we would not be able to update zigpy without also fixing zigpy-zboss and testing it by hand."

Tip when adding tests suggest also checking Home Assistant's "Development Checklist" to make sure check all those boxes too:

PS: Copy to @Maxwelltoo, as you mentioned having an interest in helping out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant