-
Notifications
You must be signed in to change notification settings - Fork 68
/
DEVELOPMENT
171 lines (137 loc) · 7.22 KB
/
DEVELOPMENT
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
!!
!! Copyright (C) 2009-2016 Johns Hopkins University
!!
!! This file is part of lesgo.
!!
!! lesgo is free software: you can redistribute it and/or modify
!! it under the terms of the GNU General Public License as published by
!! the Free Software Foundation, either version 3 of the License, or
!! (at your option) any later version.
!!
!! lesgo is distributed in the hope that it will be useful,
!! but WITHOUT ANY WARRANTY; without even the implied warranty of
!! MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
!! GNU General Public License for more details.
!!
!! You should have received a copy of the GNU General Public License
!! along with lesgo. If not, see <http://www.gnu.org/licenses/>.
!!
================================================================================
TO DO LIST
================================================================================
KEY:
(NN) items that have not been implemented
(II) items that are in progress
(CC) items that are complete
ITEMS:
(CC) Move to CMake in order to eliminate the need for out-of-date
dependencies fmakedepf90 and fpx3. This requires changing the
precompiler flags to be compatible for cpp (C preprocessor) and
writing a new CMakeLists.txt file and build process.
Assigned to CS with testing by JB and TM
CS - should work on njord, panoramix, and marcc. Ready for testing.
JB - successfully tested on njord.
(CC) Remove deprecated preprocessor flags DEBUG, VERBOSE, DBLPREC
Assigned to everyone
TM - removed DEBUG
CS - removed DBLPREC and DEVEL(never used anyway)
(CC) Make binary default output with CGNS enabled through compiler flag
CS - completed
(CC) Remove commented out references to Tecryte
Assigned to no one
This has been removed from io.f90
(CC) Remove FFTW2 support
Assigned to JB
(II) Fix some IO problems caused by removing Tecryte support
Assigned to TM
Added points writing capabilities.
Velocity as a function of time is done by having a single file
per point called point{number}.dat
This still needs to be completed for the binary output
(NN) Interpolation from restart files to allow changes in domain size,
grid size, and domain decomposition for parallelization.
Assigned to JB
(CC) Include matlab functions for reading binary output files.
Assigned to JB
After changes to output files for consistency.
(II) Related to task above (matlab functions for reading binary output files),
add a 'post_processing' folder which includes basic utilities for reading
data into MATLAB, paraview, vapor, etc.
Assigned to no one.
JB - the folder now exists and so far includes the MATLAB scripts.
(II) Cleanup unused lesgo.conf input. This is mostly restart file flags.
Assigned to no one
TM - Removed the initialization flags.
CS - Removed Ct_noprime, since you can calculate that from Ct_prime
There is still more stuff to be cleaned up
(NN) Include developer style guide. This may be contentious and will need to
be discussed and included incrementally.
Assigned to no one.
(NN) Include detailed installation notes.
Assigned to no one.
Add notes for using gfortran on marcc. Assigned to TM.
(NN) Add folder which includes basic submit scripts for different systems like
MARCC, panoramix, etc.
Assigned to no one.
(NN) Investigate the near-wall boundary issue in convec.f90 (using first vs
second grid point). Should be using first grid point but this has caused
simulation to blow up.
Assigned to no one.
(CC) Fix compilation issues with level set. Tecryte will have to be disabled and
replaced by native fortran output. Assigned to CS.
(CC) Cleanup README:
CS - cleaned up removed features
CS - fixed description of point IO
(CC) Cleanup little/big endian read and write. These are inconsistently used in
the code.
================================================================================
DEVELOPER NOTES
================================================================================
1. Output file type support:
Developers MUST support both output types (binary and CGNS). This means that
any changes or additions you make to one output type MUST be reflected in the
other output type.
2. File ID reservations:
All data files that use a fixed file identifier should be opened using
"open_file_fid" function. This function provides a mechanism for
handling the file identifiers of files that will remain open during the
simulation. It simply provides the file identifier on a first come first
serve bases starting with 1000. So if any file identifiers are to be used
that are not provided by the open_file_fid function they should be <1000,
but this is discouraged and should only be done if necessary.
3. trees_pre_ls:
This is a legacy program that may have obsolete or non-working features.
It was included to preserve the complete functionality of the level set
feature and allow new users to test the capabilities (such as arrays of cubes)
New developers using this program may want to take a closer look and clean up
this feature.
================================================================================
BROKEN FEATURES
================================================================================
1. Subgrid models 2, 3, and 4 appear to be broken at the moment
2. The spectra calculations are broken (jb)
3. The sgs histograms are disabled (This uses tecplot anyway) (cs)
================================================================================
REMOVED FEATURES
================================================================================
1. 2011-09-13: All of the original "buildings" immersed boundary modeling has
been deemed deprecated and thus removed. To obtain the latest code before the
remove refer to CVS tag: pre_immersedbc_buildings_remove
2. 2011-09-15: All of the original scalar calculations have been removed. The
scalar calculations were removed since they 1) are not currently being used
and 2) should, if reimplemented, be done in a consistent way with the current
coding constructs of lesgo. To obtain the latest code before the remove refer
to CVS tag: pre_scalar_calculations_remove
3. 2016-05-12: All of the RNS and CYL_SKEW_LS modules have been removed. These
features relied on external libraries and could not be effectively maintained.
To obtain the source code for these features look at the repository versions
prior to the posted date.
Details about these features can be found in:
* Graham, J., Meneveau, C., "Modeling turbulent flow over fractal trees using
Renormalized Numerical Simulation: Alternate formulations and numerical
experiments", Phys. of Fluids 24 (2012).
* J. Graham, K. Bai, C. Meneveau, and J. Katz. LES modeling and experimental
measurement of boundary layer flow over multi-scale, fractal canopies. In
H. Kuerten, B. Geurts, V. Armenio, and J. Froehlich, editors, Direct and
Large-Eddy Simulation VIII, volume 15 of ERCOFTAF Series, pages 233238,
2011.