Add support for backdrop-filter, among other stuff #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and other stuff, maybe?
|
Just noticed the same can be achieved with webPreferences: {
blinkFeatures: "EnumerateDevices,AudioOutputDevices",
+ experimentalFeatures: true
}But i would like to hear your opinion |
|
sure, sounds fine to add this. i'd rather put it behind a flag of some sort though. i'd also like to make it toggleable, i.e. you can pass either |
|
Actually, i just found a way to enable only backdrop filters without enabling experimental features at all, do you think a flag would still be necessary? |
|
Would it be possible to have a separate toggle for both? I'd love to try the experimental stuff but I don't really have a use for backdrop filters. |
this introduces the possibility of breaking when psutil updates, but it shouldn't be that bad.
|
I'd prefer to see a toggle for both as well as it opens up a lot more possibilities on my end. |
Pass a directory to --css and we will watch and apply changes within that directory. (We will only look at files with the .css extension). This change introduces a new restriction that single watched files also need to have the css extension. Tested: Windows Discord Canary, watching single file, watching directory, adding, removing, editing, renaming within that directory, running applyAndWatchCSS in console. Everything seems to work.
This avoids unpacking the asar since it's unnecessary. No Linux support at the moment.
tested on 10.10.5 for discordcanary
The previous location could be overridden which is not preferable.
This requires re-packing the asar file after we make our modifications which is admittedly a bit slow unfortunately but there's nothing we can do about it.
Moves it over to ~/.beautifuldiscord/cssInjection.js, should solve most of the permission errors and ceases to require root.
they made changes to make "electron" not defined apparently? So lets just define it ourselves
some users were experiencing the error even after we redefined `electron`, so it would work with some users while with others it didn't (weird). This method seems to work across the board since it's going right into the window module.
... and other stuff, maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backdrop-filter CSS adds many possibilities, but it's only available through the
--enable-experimental-web-platform-featuresflag.While one can edit all discord launchers and shortcuts to include the flag, wouldn't it be nice to have this integrated into BeautifulDiscord itself? (since it's focused at styling)
Thankfully, the Electron API provides a method to add chrome flags before launching the renderer process, and this PR makes use of said API to add the cli switch.
This might also allow some other experimental CSS features.