-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not inject on latest Canary build #51
Comments
I don't have an issue, same build. You sure you running the latest master branch? |
Yes, it update frequently. I'll tell if it will not work on next update. |
I recieve new update and B.D. still not work for me.
|
I can't reproduce this still. Same build as you. Yes, after a 'hard' update on Canary (where you have to restart the client) - I do have to re-run Are you sure you are running the latest branch ( The only thing that I can think of is if you are using Windows, on stable maybe the recent updates last Friday for voice/overlay (but only for the stable build) might have broke it. However, I seriously doubt that is the case since other Windows users seemingly can't reproduce this either, and it was just pertaining to the stable client. Can see the screenshots below in my case, after updating Discord just now: ➜ ~ beautifuldiscord --css bdmaster.css
Found Discord Canary under /Applications/Discord Canary.app/Contents/MacOS
Done!
You may now edit your /Users/shikhirarora/bdmaster.css file,
which will be reloaded whenever it's saved.
Relaunching Discord now...
|
With latest update (
Just to mention:
|
Wait, it work only partially, hot reload not work now (when I make changes to file and save), styles now updated only if I restart discord. |
@shikhir-arora Is that your own theme? If so, mind sharing? Really love the way it looks. |
@Wittyy It's the work of @AlexFlipnote using his theme which is updated frequently and some other plugins I chose using imports. They're updated frequently so it's always looking nice. Here's the CSS file I use: https://hastebin.com/oxofuzilix.css 🙂 |
Related to topicI can still inject CSS in the latest build of Canary, just tested today while I was modifying my INSTALL.bat for my theme that both installs latest BeautifulDiscord version from discord and inserts my theme. Unrelated to topicNice to see people around like you @shikhir-arora still interested in my theme, if you even want to have a chat with me, you can always find my place at the AlexFlipnote/Discord_Theme, it has my invite there. |
@AlexFlipnote Thanks for the awesome theme and plugins! And yes, just reloaded with latest Canary and the above mentioned CSS file with the plugins and it works just fine. Would expect nothing less, as the updates were mainly for Electron, so it shouldn't change the CSS injection/node properties. |
Just a reminder what with latest build it get work for me but without hot reload. |
Hot reload can be on or off depending on some things, like your CSS. It works most of the times just fine. |
app-0.0.204
[BUILD INFO] Release Channel: canary, Build Number: 14306, Version Hash: c6d6ff0164901ec2bdce707e57891c2a569b146a
The text was updated successfully, but these errors were encountered: