Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not inject on latest Canary build #51

Open
XCanG opened this issue Apr 29, 2018 · 12 comments
Open

Not inject on latest Canary build #51

XCanG opened this issue Apr 29, 2018 · 12 comments
Labels

Comments

@XCanG
Copy link

XCanG commented Apr 29, 2018

app-0.0.204

[BUILD INFO] Release Channel: canary, Build Number: 14306, Version Hash: c6d6ff0164901ec2bdce707e57891c2a569b146a

@shikhir-arora
Copy link

I don't have an issue, same build. You sure you running the latest master branch?

@XCanG
Copy link
Author

XCanG commented Apr 29, 2018

Yes, it update frequently. I'll tell if it will not work on next update.

@XCanG
Copy link
Author

XCanG commented May 1, 2018

I recieve new update and B.D. still not work for me.

[BUILD INFO] Release Channel: canary, Build Number: 14388, Version Hash: 774c099644f872bb98557e9ae1ee936fe14479aa

@shikhir-arora
Copy link

shikhir-arora commented May 1, 2018

I can't reproduce this still. Same build as you.

Yes, after a 'hard' update on Canary (where you have to restart the client) - I do have to re-run beautifuldiscord --css 99%+ of the times, but that is expected and takes like 2 seconds to do (since my CSS file doesn't change in itself as I just use imports for everything). I use macOS/Linux so I can only speak to that.

Are you sure you are running the latest branch (master, not canary) of BeautifulDiscord itself? The canary branch doesn't work/hasn't been updated for a while, but no need as the master branch works properly. Does it find the executable and try to inject? Do you have a screenshot if so?

The only thing that I can think of is if you are using Windows, on stable maybe the recent updates last Friday for voice/overlay (but only for the stable build) might have broke it. However, I seriously doubt that is the case since other Windows users seemingly can't reproduce this either, and it was just pertaining to the stable client.

Can see the screenshots below in my case, after updating Discord just now:


screen shot 2018-05-01 at 5 26 08 am
screen shot 2018-05-01 at 5 30 40 am


~ beautifuldiscord --css bdmaster.css
Found Discord Canary under /Applications/Discord Canary.app/Contents/MacOS

Done!

You may now edit your /Users/shikhirarora/bdmaster.css file,
which will be reloaded whenever it's saved.

Relaunching Discord now...

@XCanG
Copy link
Author

XCanG commented May 2, 2018

With latest update (app-0.0.206, [BUILD INFO] Release Channel: canary, Build Number: 14432, Version Hash: b1e0325580b21e818cad6c7aae22115a1ca8b7d8) I got it to work, but I get new error, may be it not related to B.D., but well:

C:\Users\X4\AppData\Local\DiscordCanary\app-0.0.206\resources\electron.asar\renderer\init.js:162
Electron Security Warning This renderer process has Node.js integration enabled and attempted to load remote content. This exposes users of this app to severe security risks.
For more information and help, consult https://electronjs.org/docs/tutorial/security

Just to mention:

EvilDabbitBOT - Today at 04:33
@Canary A new canary build is coming for all desktop platforms in ~10m. The only substantial change is an upgrade to Electron. Please report all the spoopy issues.

@XCanG
Copy link
Author

XCanG commented May 2, 2018

Wait, it work only partially, hot reload not work now (when I make changes to file and save), styles now updated only if I restart discord.

@apathy
Copy link

apathy commented May 2, 2018

@shikhir-arora Is that your own theme? If so, mind sharing? Really love the way it looks.

@shikhir-arora
Copy link

@Wittyy It's the work of @AlexFlipnote using his theme which is updated frequently and some other plugins I chose using imports. They're updated frequently so it's always looking nice. Here's the CSS file I use: https://hastebin.com/oxofuzilix.css 🙂

@AlexFlipnote
Copy link
Contributor

AlexFlipnote commented May 2, 2018

Related to topic

I can still inject CSS in the latest build of Canary, just tested today while I was modifying my INSTALL.bat for my theme that both installs latest BeautifulDiscord version from discord and inserts my theme.

Unrelated to topic

Nice to see people around like you @shikhir-arora still interested in my theme, if you even want to have a chat with me, you can always find my place at the AlexFlipnote/Discord_Theme, it has my invite there.

@shikhir-arora
Copy link

@AlexFlipnote Thanks for the awesome theme and plugins! And yes, just reloaded with latest Canary and the above mentioned CSS file with the plugins and it works just fine. Would expect nothing less, as the updates were mainly for Electron, so it shouldn't change the CSS injection/node properties.

@XCanG
Copy link
Author

XCanG commented May 2, 2018

Just a reminder what with latest build it get work for me but without hot reload.

@shikhir-arora
Copy link

Hot reload can be on or off depending on some things, like your CSS. It works most of the times just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants