Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix white space on top of tabs dividing line #12380

Merged

Conversation

AlexVelezLl
Copy link
Member

@AlexVelezLl AlexVelezLl commented Jun 28, 2024

Summary

Note: This PR depends on learningequality/kolibri-design-system#673.

Fix white space on top of coach tabs dividing line.

image
image

References

Closes #12297.

Reviewer guidance

You can go to any of these components and see that dividing line is showing correctly:

  • Tabs on Coach Reports table
  • Tabs on Coach Plan table
  • Tabs on Coach Group Reports table
  • Tabs on Coach Learner Reports table
  • Tabs on Coach Lesson Reports table
  • Tabs on Coach Quiz Reports table

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@AlexVelezLl AlexVelezLl added the TODO: needs review Waiting for review label Jun 28, 2024
@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Jun 28, 2024
@nucleogenesis nucleogenesis requested review from pcenov and removed request for pcenov June 28, 2024 21:27
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually tested this and LGTM, thanks @AlexVelezLl

@rtibbles rtibbles merged commit ab7e7e4 into learningequality:develop Jul 2, 2024
30 checks passed
@AlexVelezLl AlexVelezLl deleted the fix-ktabs-blank-space branch July 3, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs cover dividing line
3 participants